Date: Thu, 29 Aug 2019 14:42:25 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Kirill Ponomarev <krion@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r510145 - head/sysutils/screen Message-ID: <20190829124225.r7gpumnvtbeguuoz@ivaldir.net> In-Reply-To: <201908291230.x7TCUgKI027625@slippy.cwsent.com> References: <201908290638.x7T6cVFc033808@repo.freebsd.org> <201908291230.x7TCUgKI027625@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--vmfceac25l47d6el Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 29, 2019 at 05:30:42AM -0700, Cy Schubert wrote: > In message <201908290638.x7T6cVFc033808@repo.freebsd.org>, Kirill Ponomar= ev=20 > wri > tes: > > Author: krion > > Date: Thu Aug 29 06:38:31 2019 > > New Revision: 510145 > > URL: https://svnweb.freebsd.org/changeset/ports/510145 > > > > Log: > > Remove building man page by default. It's currently broken on HEAD > > and requires to build textproc/groff which requires devel/llvm80 > > which is an overkill for using screen. > > > > Modified: > > head/sysutils/screen/Makefile > > > > Modified: head/sysutils/screen/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > =3D > > --- head/sysutils/screen/Makefile Thu Aug 29 06:37:17 2019 (r51014 > > 4) > > +++ head/sysutils/screen/Makefile Thu Aug 29 06:38:31 2019 (r51014 > > 5) > > @@ -3,7 +3,7 @@ > > =20 > > PORTNAME=3D screen > > PORTVERSION=3D 4.6.2 > > -PORTREVISION=3D 1 > > +PORTREVISION=3D 2 > > CATEGORIES=3D sysutils > > MASTER_SITES=3D GNU \ > > ftp://ftp.gnu.org/gnu/screen/ \ > > @@ -20,7 +20,7 @@ COMMENT=3D Multi-screen window manager > > LICENSE=3D GPLv3 > > =20 > > OPTIONS_DEFINE=3D INFO MAN NETHACK XTERM_256 SHOWENC SYSTEM_SCREE > > NRC > > -OPTIONS_DEFAULT=3D INFO MAN NETHACK XTERM_256 SOCKETS SYSTEM_SCREENRC \ > > +OPTIONS_DEFAULT=3D INFO NETHACK XTERM_256 SOCKETS SYSTEM_SCREENRC \ > > NCURSES_DEFAULT > > OPTIONS_SINGLE=3D IPC NCURSES > > OPTIONS_SINGLE_IPC=3D SOCKETS NAMED_PIPES > > >=20 > Should you not have obtained maintainer approval for this first? >=20 > And now the package will not include man pages. Can I assign those PRs to= =20 > you? >=20 I do think the best approach to this is to drop the MAN page option, it mak= es little sense not to install it. and not add groff as a runtime dependency anyway. The reason why man(1) is telling the users to install groff(1) is exactly f= or that, the users do decide if he wants to read that manpage on his system an= d do install groff, or he reads it online and do not install it at all. the other point is in the future screen(1) might become mandoc compatible. and you wi= ll still grab in the groff(1) dependency. Best regards, Bapt --vmfceac25l47d6el Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl1nyC8ACgkQY4mL3PG3 Plp9BQ/+Lkf2XEg+gH24w7cZHsCd9LWM6Q6etXgEzOATKeLqa7ZVK7wvFcOspf+5 ln7thGlWz6/d93/wkm8KCAhkeZJ0CgpcRFisKKDIoxB50LchVLuHD3hfIjeyYgPZ jlWx+c1D+bzqIjJP0iXdCmTtHLBGnf7WwFH1jiuQGo8vxAZw+D47//xV3H563Jhx 1ILJKfmrBofHRqh4W7eSZnorEKYql9Oh7ioYDjqEZKOsyUkmX+ofJGCc+NRcpJ+5 nAnu3aiXDjl5QMep012bpS0xwjleFx/j5KX7NsuHNOj20sAMitOEXuLz3RzXloSq 7gippRDK+42X88cx2AdKAMyK2PrBycgcRVxPpgqUiJni2DebfSD/SZvu5HES29JD 14p17baREx6JwgXGEr/Dei/2CxeYv+5RgVoAZDz8wnnlWcpBsbWOgQVzbVawPYEC zh/PkxufFrKFII4wifwh1US9JURPdeXqsX4KAgYlUuv3RM5ii2mPtDjnuMpFOCXf cZgry55YT/Er6r49sfrGxd8qP6LGkSzcKO6h4/3siKUhEUxkc5bAPINVj4j8n37A Nh/aAYda5DqrJDjtu/3In6oEx0lN32u19S+VUaqYIOIIbQbJhFQeG6BjK9ucAmwG L9W5SRTjt6lkEcS3oMDk1aEXBNiL8gH2O41hD86jp5xOFfrjRrg= =K8NV -----END PGP SIGNATURE----- --vmfceac25l47d6el--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190829124225.r7gpumnvtbeguuoz>