From owner-cvs-all@FreeBSD.ORG Fri Apr 2 16:42:34 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 848B916A4CE; Fri, 2 Apr 2004 16:42:34 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7ED2243D31; Fri, 2 Apr 2004 16:42:34 -0800 (PST) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i330gYGe058047; Fri, 2 Apr 2004 16:42:34 -0800 (PST) (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i330gYi7058046; Fri, 2 Apr 2004 16:42:34 -0800 (PST) (envelope-from ru) Message-Id: <200404030042.i330gYi7058046@repoman.freebsd.org> From: Ruslan Ermilov Date: Fri, 2 Apr 2004 16:42:33 -0800 (PST) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/pci if_rl.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Apr 2004 00:42:34 -0000 ru 2004/04/02 16:42:33 PST FreeBSD src repository Modified files: sys/pci if_rl.c Log: Fixed a few bugs in the rl(4) driver: Under polling(4), we counted non-existent output packets and wasted CPU cycles, corrected. (PR kern/64975.) The fix in revision 1.71 to correct resetting of the watchdog timer was wrong. In rl(4), the TX list does not have a gap between the consumer and producer, so the "empty TX list" test was wrong, corrected. Also, resetting the timer to five each time we know there is still some TX work to do was a bad idea -- under polling(4), if the chip goes out to lunch, this results in the watchdog routine to _never_ be called. Instead, let the timer downgrade to zero and fire the watchdog, then reset it to five when it is zero AND there is some TX work left. (Most other network drivers need this fix too.) MFC after: 3 days Revision Changes Path 1.134 +10 -8 src/sys/pci/if_rl.c