From owner-svn-ports-all@FreeBSD.ORG  Thu Jun  4 16:37:39 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id AA15F38C;
 Thu,  4 Jun 2015 16:37:39 +0000 (UTC)
 (envelope-from tijl@freebsd.org)
Received: from mailrelay106.isp.belgacom.be (mailrelay106.isp.belgacom.be
 [195.238.20.133])
 by mx1.freebsd.org (Postfix) with ESMTP id EE61D1301;
 Thu,  4 Jun 2015 16:37:38 +0000 (UTC)
 (envelope-from tijl@freebsd.org)
X-Belgacom-Dynamic: yes
X-Cloudmark-SP-Filtered: true
X-Cloudmark-SP-Result: v=1.1 cv=SBTPB+aU5K4LG/z6P+2X+Qo0AxOejQ4nyx+IVoQ/YQ8=
 c=1 sm=2
 a=kj9zAlcOel0A:10 a=tITsiVaQAAAA:8 a=6I5d2MoRAAAA:8
 a=YP7DcIupFBReM-cPXb4A:9 a=CjuIK1q_8ugA:10
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A2BvBgBHfnBV/++YsFtbgxCBMrEolHkCgTdNAQEBAQEBgQuEIwEBBDocIxALDgoJJQ8qHgYTiBgDFgHWPiCEfgEBAQEBAQEDAQEBAQEdi0OFBgeELQEEnj2XUSSDeTwxgkcBAQE
Received: from 239.152-176-91.adsl-dyn.isp.belgacom.be (HELO
 kalimero.tijl.coosemans.org) ([91.176.152.239])
 by relay.skynet.be with ESMTP; 04 Jun 2015 18:35:58 +0200
Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org
 [127.0.0.1])
 by kalimero.tijl.coosemans.org (8.14.9/8.14.9) with ESMTP id t54GZuwi004099;
 Thu, 4 Jun 2015 18:35:57 +0200 (CEST)
 (envelope-from tijl@FreeBSD.org)
Date: Thu, 4 Jun 2015 18:35:56 +0200
From: Tijl Coosemans <tijl@FreeBSD.org>
To: Jan Beich <jbeich@vfemail.net>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r388498 - head/multimedia/dvdstyler
Message-ID: <20150604183556.57937749@kalimero.tijl.coosemans.org>
In-Reply-To: <twun-ef5q-wny@vfemail.net>
References: <201506040756.t547uJN4005594@svn.freebsd.org>
 <twun-ef5q-wny@vfemail.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Jun 2015 16:37:39 -0000

On Thu, 04 Jun 2015 16:12:17 +0200 Jan Beich <jbeich@vfemail.net> wrote:
> Tijl Coosemans <tijl@FreeBSD.org> writes:
>>   - Replace CXXFLAGS+=-std=c++11 with USE_CXXSTD.
> [...]
>> +USE_CXXSTD=	gnu++11
> [...]
>> -.if ${CHOSEN_COMPILER_TYPE} == "gcc"
>> -CXXFLAGS+=	-std=c++11
>> -.endif
> 
> Why "gnu" dialect of c++11 ? If clang/libc++ fail to build the port
> otherwise you should say so in the commit message. At least r383466
> itself doesn't require "gnu".
> 
> $ fgrep -i std x11-toolkits/wxgtk30/Makefile
> CXXFLAGS+=      -std=c++11

Hmm, I see the gnu dialect as the normal case and strict standard
compliance as the special case requiring explanation.  The reason is
that the compiler uses the gnu dialect by default and disables some
optimisations when you request strict compliance.  If upstream relied
on strict compliance they would have added an -std flag themselves.

So in my opinion wxgtk30 should also use -std=gnu++11.