From owner-freebsd-net@FreeBSD.ORG Fri Mar 29 16:38:20 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 24C0B421 for ; Fri, 29 Mar 2013 16:38:20 +0000 (UTC) (envelope-from barney_cordoba@yahoo.com) Received: from nm20-vm3.bullet.mail.ne1.yahoo.com (nm20-vm3.bullet.mail.ne1.yahoo.com [98.138.91.150]) by mx1.freebsd.org (Postfix) with ESMTP id BE9D8EDB for ; Fri, 29 Mar 2013 16:38:19 +0000 (UTC) Received: from [98.138.90.56] by nm20.bullet.mail.ne1.yahoo.com with NNFMP; 29 Mar 2013 16:38:13 -0000 Received: from [98.138.89.249] by tm9.bullet.mail.ne1.yahoo.com with NNFMP; 29 Mar 2013 16:38:13 -0000 Received: from [127.0.0.1] by omp1041.mail.ne1.yahoo.com with NNFMP; 29 Mar 2013 16:38:13 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 116813.73420.bm@omp1041.mail.ne1.yahoo.com Received: (qmail 75373 invoked by uid 60001); 29 Mar 2013 16:38:13 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1364575093; bh=IaBDNWRrhp1cCzTi10sVLF97aUR3J26yGWl7UjYQVYA=; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:Message-ID:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type; b=SqV7z3i255b+4de9zJgIK2p0SFdfqKGJZrOi6BLMDFXCdLeIdCThLvSLLQMrc+S+usLmTLao3vre4hmcnouqeovQ960umsb5ffO6phhYh+DCwrh//Yq/VgRIxzVLhIKTTAs8NxK0pcu6lcWPtoPxQ4B08cS9MyLWTICnfGm3dLk= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:Message-ID:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type; b=VAVJk8ajY83yvRCF2rKvorS+R/0kCPXlvOseENWhWa9uZPMzl77tNDQjGm+MuQyCZgb8eqb2E20VrXOxsMeWI7wnqCreMucPU7Gc+hn7NoTa8pW3JbbKwe9YkCJR7rFPrzg2sJq6sRPO2auPSK1S68xymUe0izC3BLwe6CUwAHU=; X-YMail-OSG: 66QEh9EVM1moOjSftUOueGCjHfQ.qwmtJXu1W2beXmYVafO C1X9YEzhyto6luWnaUGT0wYfpnI3x0_NQB1wdSJnQuW2r3kTvBmcR5GhMz_. R24xCFwC0WpBpCHBQjPOmcVmhPk5NotxMhT21KiocBzij7hwb18DNkm4ePAf _WvcgtqRCOqUuGVkPzERCJkACKakOVhHmfqowzjZ7DlIADn7eP.2wwVhvLgs VDl5BTsfgzKySrOeklDHs6CvitljfbtEk7D9jPjUe5obSQzWN7Ts7HC5xSh. 1sHwjqU5DF1ZUKV.aQBPQWvrfVQZpGqU8HHT63GjOoitzRlSvA3XYQ8hJ_L5 GdtsV5R8chREZRiTvpeUhhBN_IvlS8DAD4nAqR4scumXw3OkYZcaBAJ7mpPI 1JfrGO2ivRwIAdCWIHumrlVcpVGXNu_YVwGXe5wZLlIhpspe7XQ_inxRJ9rG e3.q2uhLXsJqw7YNZ4ArkKFAZ7yQv3dcSqbqId7ovJeZpcVz5syAECbzK_hS UDwXmCQqyVdD7N8ouAvaXO_e_XMlwZg-- Received: from [98.203.118.124] by web121604.mail.ne1.yahoo.com via HTTP; Fri, 29 Mar 2013 09:38:12 PDT X-Rocket-MIMEInfo: 002.001, aXQgbmVlZHMgYSBsb3QgbW9yZSB0aGFuIGEgcGF0Y2guIEl0IG5lZWRzIHRvIGJlIGNvbXBsZXRlbHkgcmUtdGh1bmsNCg0KLS0tIE9uIEZyaSwgMy8yOS8xMywgQWRyaWFuIENoYWRkIDxhZHJpYW5AZnJlZWJzZC5vcmc.IHdyb3RlOg0KDQpGcm9tOiBBZHJpYW4gQ2hhZGQgPGFkcmlhbkBmcmVlYnNkLm9yZz4NClN1YmplY3Q6IFJlOiBpZ2IgYW5kIEFMVFEgaW4gOS4xLXJjMw0KVG86ICJCYXJuZXkgQ29yZG9iYSIgPGJhcm5leV9jb3Jkb2JhQHlhaG9vLmNvbT4NCkNjOiAiSmFjayBWb2dlbCIgPGpmdm9nZWwBMAEBAQE- X-Mailer: YahooMailClassic/15.1.7 YahooMailWebService/0.8.139.530 Message-ID: <1364575092.74048.YahooMailClassic@web121604.mail.ne1.yahoo.com> Date: Fri, 29 Mar 2013 09:38:12 -0700 (PDT) From: Barney Cordoba Subject: Re: igb and ALTQ in 9.1-rc3 To: Adrian Chadd In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: Nick Rogers , Jeffrey EPieper , "Clement Hermann \(nodens\)" , Jack Vogel , "freebsd-net@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Mar 2013 16:38:20 -0000 it needs a lot more than a patch. It needs to be completely re-thunk --- On Fri, 3/29/13, Adrian Chadd wrote: From: Adrian Chadd Subject: Re: igb and ALTQ in 9.1-rc3 To: "Barney Cordoba" Cc: "Jack Vogel" , "Nick Rogers" , "Jeffrey EPieper" , "freebsd-net@freebsd.org" , "Clement Hermann (nodens)" Date: Friday, March 29, 2013, 12:07 PM Barney, Patches gratefully accepted. Adrian On 29 March 2013 08:54, Barney Cordoba wrote: --- On Fri, 3/29/13, Pieper, Jeffrey E wrote: > From: Pieper, Jeffrey E > Subject: RE: igb and ALTQ in 9.1-rc3 > To: "Barney Cordoba" , "Jack Vogel" , "Nick Rogers" > Cc: "freebsd-net@freebsd.org" , "Clement Hermann (nodens)" > Date: Friday, March 29, 2013, 11:45 AM > > > -----Original Message----- > From: owner-freebsd-net@freebsd.org > [mailto:owner-freebsd-net@freebsd.org] > On Behalf Of Barney Cordoba > Sent: Friday, March 29, 2013 5:51 AM > To: Jack Vogel; Nick Rogers > Cc: freebsd-net@freebsd.org; > Clement Hermann (nodens) > Subject: Re: igb and ALTQ in 9.1-rc3 > > > > --- On Thu, 3/28/13, Nick Rogers > wrote: > > > From: Nick Rogers > > Subject: Re: igb and ALTQ in 9.1-rc3 > > To: "Jack Vogel" > > Cc: "Barney Cordoba" , > "Clement Hermann (nodens)" , > "freebsd-net@freebsd.org" > > > Date: Thursday, March 28, 2013, 9:29 PM > > On Thu, Mar 28, 2013 at 4:16 PM, Jack > > Vogel > > wrote: > > > Have been kept fairly busy with other matters, > one > > thing I could do short > > > term is > > > change the defines in igb the way I did in the em > > driver so you could still > > > define > > > the older if_start entry. Right now those are > based on > > OS version and so you > > > will > > > automatically get if_transmit, but I could change > it to > > be IGB_LEGACY_TX or > > > so, > > > and that could be defined in the Makefile. > > > > > > Would this help? > > > > I'm currently using ALTQ successfully with the em > driver, so > > if igb > > behaved the same with respect to using if_start instead > of > > if_transmit > > when ALTQ is in play, that would be great. I do not > > completely > > understand the change you propose as I am not very > familiar > > with the > > driver internals. Any kind of patch or extra > > Makefile/make.conf > > definition that would allow me to build a 9-STABLE > kernel > > with an igb > > driver that works again with ALTQ, ASAP, would be much > > appreciated. > > > > > > > > Jack > > > > > > > > > > > > On Thu, Mar 28, 2013 at 2:31 PM, Nick Rogers > > > wrote: > > >> > > >> On Tue, Dec 11, 2012 at 1:09 AM, Jack Vogel > > > wrote: > > >> > On Mon, Dec 10, 2012 at 11:58 PM, Gleb > > Smirnoff > > >> > wrote: > > >> > > > >> >> On Mon, Dec 10, 2012 at 03:31:19PM > -0800, > > Jack Vogel wrote: > > >> >> J> UH, maybe asking the owner of > the > > driver would help :) > > >> >> J> > > >> >> J> ... and no, I've never been > aware of > > doing anything to stop > > >> >> supporting > > >> >> altq > > >> >> J> so you wouldn't see any > commits. If > > there's something in the altq > > >> >> code > > >> >> or > > >> >> J> support (which I have nothing > to do > > with) that caused this no-one > > >> >> informed > > >> >> J> me. > > >> >> > > >> >> Switching from if_start to > if_transmit > > effectively disables ALTQ > > >> >> support. > > >> >> > > >> >> AFAIR, there is some magic > implemented in > > other drivers that makes them > > >> >> modern (that means using > if_transmit), but > > still capable to switch to > > >> >> queueing > > >> >> mode if SIOCADDALTQ was casted upon > them. > > >> >> > > >> >> > > >> > Oh, hmmm, I'll look into the matter after > my > > vacation. > > >> > > > >> > Jack > > >> > > >> Has there been any progress on resolving this > > issue? I recently ran > > >> into this problem upgrading my servers from > 8.3 to > > 9.1-RELEASE and am > > >> wondering what the latest recommendation is. > I've > > used ALTQ and igb > > >> successfully for years and it is unfortunate > it no > > longer works. > > >> Appreciate any advice. > > >> > > > >Do yourself a favor and either get a cheap dual port > 82571 card or > >2 cards and disable the IGB ports. The igb driver is > defective, and until > >they back out the new, untested multi-queue stuff you're > just neutering > >your system trying to use it. > > > >Frankly this project made a huge mistake by moving > forward with multi > >queue just for the sake of saying that you support it; > without having > >any credible plan for implementing it. That nonsense > that Bill Macy did > >should have been tarballed up and deposited in the trash > folder. The > >biggest mess in programming history. > > > >That being said, the solution is not to hack the igb > driver; its to make > >ALTQ if_transmit compatible, which shouldn't be all that > difficult. > > > >BC > > I may be misunderstanding what you are saying, but if the > solution is, as you say "not to hack the igb driver", then > how is it defective in this case? Or are you just directing > vitriol toward Intel? Multi-queue is working fine in igb. > > Jeff It's defective because it's been poorly implemented and has more bugs than a Manhattan hotel bed. Adding queues without a proper plan just add more lock contention. It's not a production-ready driver. As Jack once said, Intel doesn't care about performance, they're just example drivers. igb is an example of how not to do things. BC _______________________________________________ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"