From owner-svn-src-all@freebsd.org Thu Nov 29 16:25:42 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 76C5F1142CED for ; Thu, 29 Nov 2018 16:25:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id ADD17736CB for ; Thu, 29 Nov 2018 16:25:41 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x82d.google.com with SMTP id d19so2583860qtq.9 for ; Thu, 29 Nov 2018 08:25:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QQyHxEi/4wPejAfq+DK8DytiFvsdI7KGd9Rd+7wXqiA=; b=Ip3+d9ENWEf9m1eznkbNm5XzqZYEh+27EaDwYyXtfWkUQfDGovWfZB4Vu1ckX3krJl CltpcUgWiaaA0u2RfNpqW2IxDEH017jb9ZotBKJHNZKocfQkMSWfby+mBlw/s7klLyFb 2y7l1gdHnCqHVU3PjJ+HGC6c/rJiqj3Z9DqNjdZS8nUv8qQE4YCvJo59FLzeecVZolrf 9xAFC8UAV7WtxBWdi2uDBLhdeBSSGV9TNRZ4n97I7bvHMKz1FGGZa4cdzQDIr3eqvuhq oYMTr4TVEPST0BDNRYrl8mYgu+LDmwJ6yN4/lFJaOiBjss9w7sJmowmKff7eYVXUKl+9 9vjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QQyHxEi/4wPejAfq+DK8DytiFvsdI7KGd9Rd+7wXqiA=; b=mbU8SORIRqFM7h4iEzH84PpMcX4cq5pcQzzwwOIdoPQ3+0xnVMcCVfMXp/TUfax8Hs xi6pPG5DygYNF+H1YYJFu1vpxEP1JukmMu8JTXagJ6bioGxbC6uPg9YZSgN25HnZn3Gh ViWRl/2XA+oeWavlm+PSNva0rLqm8ThVSjh18ezC9AHLdlxQkkQnJzhpxkcYiOPyH8C6 sMautcr5syVYL4dUBCjiRTtanilCYQ37fTGM4htb1Pcw5pUZIUSLripnnMPgiDnPgoLA F+rSE5cVMqL9W7+r4lFE/sm+G+qJoEJo7GyiABe4W1Hdo4tB9QKscQtkqWuVw9ryUCnv fBUA== X-Gm-Message-State: AA+aEWZrHjKAKubAwj9bUPFarArXNcvhNrhTnKQzQBIH7oyQbbB8VRsF tsLHlTTuytcvIUFoADNTmZ72aTHj0M7PRJnRJYbgrg== X-Google-Smtp-Source: AFSGD/Vpm8JMWe9wa9/MGnFOkuLS0OpMhEn/fUMIw20W1F0Q7MZ07zy8S7N6YSAeRCO3GlRrnwd0G5xG+7LDQ3+OSGM= X-Received: by 2002:a0c:bd15:: with SMTP id m21mr2049681qvg.57.1543508741159; Thu, 29 Nov 2018 08:25:41 -0800 (PST) MIME-Version: 1.0 References: <201811291421.wATELQbx059318@repo.freebsd.org> In-Reply-To: <201811291421.wATELQbx059318@repo.freebsd.org> From: Warner Losh Date: Thu, 29 Nov 2018 09:25:30 -0700 Message-ID: Subject: Re: svn commit: r341232 - in head/usr.bin: . trim To: Eugene Grosbein Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: ADD17736CB X-Spamd-Result: default: False [-3.62 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.997,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[cached: ALT1.aspmx.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[d.2.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.98)[-0.984,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-0.63)[ipnet: 2607:f8b0::/32(-1.74), asn: 15169(-1.33), country: US(-0.09)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 16:25:42 -0000 On Thu, Nov 29, 2018 at 7:21 AM Eugene Grosbein wrote: > Author: eugen > Date: Thu Nov 29 14:21:26 2018 > New Revision: 341232 > URL: https://svnweb.freebsd.org/changeset/base/341232 > > Log: > Add new small tool trim(1) to delete contents for blocks on flash > based storage devices that use wear-leveling algorithms. > > Reviewed by: hackers@ > I gave only my preliminary comments there. There were many other things that I'd planned on commenting on once this hit Phabricator. Since there were no revised version posted, it was hard to do a line-by-line review. It was at most commented upon by hackers@. The discussion for a name was good there, but since the code wasn't ever posted there (just a pointer to it), it was hard to do a real review. Warner