From owner-freebsd-hackers@FreeBSD.ORG Thu Apr 22 15:58:38 2010 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EDF9A1065672 for ; Thu, 22 Apr 2010 15:58:37 +0000 (UTC) (envelope-from gary.jennejohn@freenet.de) Received: from mout5.freenet.de (mout5.freenet.de [IPv6:2001:748:100:40::2:7]) by mx1.freebsd.org (Postfix) with ESMTP id 5D8078FC16 for ; Thu, 22 Apr 2010 15:58:37 +0000 (UTC) Received: from [195.4.92.19] (helo=9.mx.freenet.de) by mout5.freenet.de with esmtpa (ID gary.jennejohn@freenet.de) (port 25) (Exim 4.72 #3) id 1O4ynU-00088a-3I; Thu, 22 Apr 2010 17:58:36 +0200 Received: from p57ae1198.dip0.t-ipconnect.de ([87.174.17.152]:42923 helo=ernst.jennejohn.org) by 9.mx.freenet.de with esmtpa (ID gary.jennejohn@freenet.de) (port 25) (Exim 4.72 #3) id 1O4ynT-0000FO-Pt; Thu, 22 Apr 2010 17:58:36 +0200 Date: Thu, 22 Apr 2010 17:58:35 +0200 From: Gary Jennejohn To: "Julian H. Stacey" Message-ID: <20100422175835.280917c3@ernst.jennejohn.org> In-Reply-To: <201004220954.o3M9sUxM077377@fire.js.berklix.net> References: <20100422111440.69a017b2@ernst.jennejohn.org> <201004220954.o3M9sUxM077377@fire.js.berklix.net> X-Mailer: Claws Mail 3.7.5 (GTK+ 2.18.7; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: hackers@freebsd.org Subject: Re: /sys/amd64/conf/GENERIC COMPAT_FREEBSD7 a prerequisite for COMPAT_IA32 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: gary.jennejohn@freenet.de List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2010 15:58:38 -0000 On Thu, 22 Apr 2010 11:54:29 +0200 "Julian H. Stacey" wrote: > Hi, > Reference: > > From: Gary Jennejohn > > Reply-to: gary.jennejohn@freenet.de > > Date: Thu, 22 Apr 2010 11:14:40 +0200 > > Message-id: <20100422111440.69a017b2@ernst.jennejohn.org> > > Gary Jennejohn wrote: > > On Wed, 21 Apr 2010 20:57:59 +0200 > > "Julian H. Stacey" wrote: > > > > > Hi hackers@freebsd.org > > > with amd64, but not with i386, > > > /sys/amd64/conf/GENERIC COMPAT_FREEBSD7 is an undocemneted > > > pre-requisite for COMPAT_IA32 > > > (so those who enable COMPAT_IA32 for ports/emulators, but disable > > > COMPAT_FREEBSD7 as they compile all binaries on upgrade, will trip > > > up on it as I did). Currently I see: > > > > > > cc -c -O2 -frename-registers -pipe -fno-strict-aliasing -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc -I. -I../../.. -I../../../contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-omit-frame-pointer -mcmodel=kernel -mno-red-zone -mfpmath=387 -mno-sse -mno-sse2 -mno-sse3 -mno-mmx -mno-3dnow -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -Werror ../../../compat/freebsd32/freebsd32_misc.c > > > cc1: warnings being treated as errors > > > ../../../compat/freebsd32/freebsd32_misc.c: In function 'freebsd32_semsys': > > > ../../../compat/freebsd32/freebsd32_misc.c:1420: warning: implicit declaration of function 'freebsd7_freebsd32_semctl' > > > ../../../compat/freebsd32/freebsd32_misc.c:1420: warning: nested extern declaration of 'freebsd7_freebsd32_semctl' > > > ... > > > ../../../compat/freebsd32/freebsd32_misc.c:1845: error: dereferencing pointer to incomplete type > > > *** Error code 1 > > > > > > It could be documented in GENERIC, but better to fix it. I could > > > dig through sources, but I think there's people closer to config > > > who would prefer to commit their own fix, rather than me write a patch ? > > > (Does that translate as "I'm lazy" ? ;-) > > > > > > > The switch is documented in /usr/src/UPDATING on my box. This is the > > usual place for this kind of heads-up. > > Thanks Gary, > It seems COMPAT_FREEBSD7 has more scope than [456] > ( /usr/src/UPDATING I should read more often. ) > > But /usr/src/UPDATING is a transition log, & as new things occur, > the entry re COMPAT_FREEBSD7 will get buried deeper. > > Requirement from COMPAT_IA32 for COMPAT_FREEBSD7 applies with > amd64 but not i386, so I'd suggest that could be documented in > /sys/amd64/conf/GENERIC , eg > > From > options COMPAT_FREEBSD7 # Compatible with FreeBSD7 > To > options COMPAT_FREEBSD7 # Compatible with FreeBSD7, req. by COMPAT_IA32 > You're right. It's also in /sys/amd64/conf/NOTES, which is actually the place where valid flags are supposed to be documented. GENERIC actually has a different role. Note that I'm running -current, but it should also be there on other releases. -- Gary Jennejohn