From owner-freebsd-ports Mon Oct 9 9:42:23 2000 Delivered-To: freebsd-ports@freebsd.org Received: from shale.csir.co.za (shale.csir.co.za [146.64.46.5]) by hub.freebsd.org (Postfix) with ESMTP id A6B9C37B66D; Mon, 9 Oct 2000 09:42:15 -0700 (PDT) Received: from C992631-A.pinol1.sfba.home.com (C992631-A.pinol1.sfba.home.com [24.12.58.155]) by shale.csir.co.za (8.9.3/8.9.3) with ESMTP id SAA58149; Mon, 9 Oct 2000 18:41:58 +0200 (SAT) (envelope-from reg@shale.csir.co.za) Received: (from reg@localhost) by C992631-A.pinol1.sfba.home.com (8.11.0/8.11.0) id e99GfX400987; Mon, 9 Oct 2000 09:41:33 -0700 (PDT) (envelope-from reg) Date: Mon, 9 Oct 2000 09:41:33 -0700 From: Jeremy Lea To: Maxim Sobolev Cc: ports@FreeBSD.org, asami@FreeBSD.org Subject: Re: Problems with bsd.gnome.mk [patch] Message-ID: <20001009094132.H30468@shale.csir.co.za> References: <39E184FE.7FCE1E41@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <39E184FE.7FCE1E41@FreeBSD.org>; from sobomax@FreeBSD.org on Mon, Oct 09, 2000 at 11:42:38AM +0300 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Hi, On Mon, Oct 09, 2000 at 11:42:38AM +0300, Maxim Sobolev wrote: > I wonder if anyone noticed that bsd.gnome.mk does quite strange things with > package names when WANT_* defined, so example if you have WANT_GNOME defined in > your /etc/make.conf and gnome is in fact installed: Try defining WITH_GTK in /etc/make.conf and come back to me on this. The behaviuor is entirely intentional, if you happen to read the documentation. WANT is for a port's makefile. > Also I don't like the fact that bsd.gnome.mk adds > --localstatedir=${PREFIX}/share/gnome and --datadir=${PREFIX}/share/gnome > configure arguments even for those ports, which contains optional GNOME > dependencies, so for example port installs its files into ${PREFIX}/share/foo > for nognome case, but into ${PREFIX}/share/gnome/foo if WANT_GNOME is defined > (for example sawfish, xmms etc.). IMO this leads to confusion and doesn't > really necessary. At least this stuff should be made optional, so only ports > which really can benefit from that would use this feature. As an example of > possible problems with this behaviour, please considering somebody writing a > port of sawfish theme - and confusion as to where the theme files should go - > into share/gnome/safwish, or share/sawfish. Other packages may have similar > problems. This is an unfortunate sideeffect of a policy decision by both Vanilla and I when we origionally ported Gnome. We decided that all Gnome apps should put their data in ${X11BASE}/share/gnome. I'm not entirely sure that preventing this behaviour is a good thing. It leads to Gnome apps being ported in two possible ways: Patching to remove /gnome from after datadir and helpdir, and patching to add /gnome after pixmapdir. Solving the problem from a port's perspective is also fairly simple. You define WANT_GNOME, and then test HAVE_GNOME and define USE_GNOME. You can then use %%DATADIR%% to get the correct PLIST entries. It looks lile I mananged to screw up with sawfish. The Makefile shouldn't have had PLIST_SUB's for GNOME in it after I was finnished, and the PLIST should have had %%DATADIR%%'s. Sorry. I'll consider something to turn this off, but only in the case where Gnome is optional. Regards, -Jeremy -- FreeBSD - Because the best things in life are free... http://www.freebsd.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message