From owner-cvs-all Mon Sep 11 16:36:29 2000 Delivered-To: cvs-all@freebsd.org Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by hub.freebsd.org (Postfix) with ESMTP id 5EED437B422; Mon, 11 Sep 2000 16:36:23 -0700 (PDT) Received: (from grog@localhost) by wantadilla.lemis.com (8.11.0/8.9.3) id e8BNZxO79937; Tue, 12 Sep 2000 09:05:59 +0930 (CST) (envelope-from grog) Date: Tue, 12 Sep 2000 09:05:59 +0930 From: Greg Lehey To: Bruce Evans Cc: Doug Rabson , John Baldwin , Doug Rabson , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys ktr.h Message-ID: <20000912090559.M19431@wantadilla.lemis.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: ; from bde@zeta.org.au on Mon, Sep 11, 2000 at 08:36:46PM +1100 Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.lemis.com/~grog X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Monday, 11 September 2000 at 20:36:46 +1100, Bruce Evans wrote: > On Mon, 11 Sep 2000, Doug Rabson wrote: >> On Mon, 11 Sep 2000, Bruce Evans wrote: >>> The ktr macros are inefficient, so another division wouldn't be >>> much more of a disaster for performance. >> >> The KTR_EXTEND ones are very slow but the non-extended ones are a >> bit more reasonable. > > The KTR_EXTEND version of _TR would be reasonable if it used > strncpy() instead of snprintf(). Not really. The whole reason for KTR_EXTEND is to be able to see something useful in gdb, which can't apply the parameters to printf. If you're not using gdb, you don't need KTR_EXTEND. Greg -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message