From owner-freebsd-ports@FreeBSD.ORG  Sat Mar 15 04:58:10 2008
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C0DFF1065695
	for <ports@FreeBSD.org>; Sat, 15 Mar 2008 04:58:10 +0000 (UTC)
	(envelope-from d.lohansky@zsupport.ru)
Received: from tvfaq.ru (tvfaq.ru [213.248.59.4])
	by mx1.freebsd.org (Postfix) with ESMTP id 74DBB8FC21
	for <ports@FreeBSD.org>; Sat, 15 Mar 2008 04:58:09 +0000 (UTC)
	(envelope-from d.lohansky@zsupport.ru)
Received: from ppp85-140-160-63.pppoe.mtu-net.ru ([85.140.160.63]
	helo=[127.0.0.1]) by tvfaq.ru with esmtpsa (TLSv1:AES256-SHA:256)
	(Exim 4.69 (FreeBSD)) (envelope-from <d.lohansky@zsupport.ru>)
	id 1JaO8p-000EVa-9G
	for ports@FreeBSD.org; Sat, 15 Mar 2008 07:37:07 +0300
Message-ID: <47DB5242.4040509@zsupport.ru>
Date: Sat, 15 Mar 2008 07:36:18 +0300
From: =?UTF-8?B?0JTQvNC40YLRgNC40Lkg0JvQvtGF0LDQvdGB0LrQuNC5?=
	<d.lohansky@zsupport.ru>
User-Agent: Thunderbird 2.0.0.12 (Windows/20080213)
MIME-Version: 1.0
To: ports@FreeBSD.org
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: 
Subject: patch for net-mgmt/zabbix
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Mar 2008 04:58:10 -0000


There is  a path "patch-src__libs__zbxcomms__comms.c"

--- src/libs/zbxcomms/comms.c.orig      2008-03-15 07:23:00.000000000 +0300
+++ src/libs/zbxcomms/comms.c   2008-03-15 07:24:09.000000000 +0300
@@ -698,7 +698,7 @@

         for(i = 0; i < s->num_socks; i++) {
  #if !defined(_WINDOWS)
-               if(s->sockets[i] > n)
+               if(s->sockets[i] + 1 > n)
                         n = s->sockets[i] + 1;
  #endif
                 if(FD_ISSET(s->sockets[i], &sock_set))


As I know, in select(ndfs, ...), ndfs must be max descriptor + 1.
So, zabbix have a little bug, some connections in zbx_tcp_accept() will be not accepted,
because their socket descriptors are not in the ndfs.

This patch resolve troubles with "ZBX_TCP_READ() failed [Interrupted system call]" issue
from http://www.zabbix.com/forum/showthread.php?t=8870&mode=linear and other related.


-- 
With best regards, Dmitry Lohansky.

LTD "Z-Solutions"
http://www.zsupport.ru