From owner-svn-src-head@freebsd.org Sun Oct 21 15:01:03 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 33A6CFF582A; Sun, 21 Oct 2018 15:01:03 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8AA6291662; Sun, 21 Oct 2018 15:01:02 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w9LF0xfQ005429; Sun, 21 Oct 2018 08:00:59 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w9LF0xXs005428; Sun, 21 Oct 2018 08:00:59 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201810211500.w9LF0xXs005428@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r339436 - in head: . contrib/gcc gnu/usr.bin/cc/cc_tools lib/clang release sys/conf sys/sys In-Reply-To: To: Jan Beich Date: Sun, 21 Oct 2018 08:00:59 -0700 (PDT) CC: Dimitry Andric , Glen Barber , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Oct 2018 15:01:03 -0000 > Dimitry Andric writes: > > > On 21 Oct 2018, at 04:08, Jan Beich wrote: > > > >> > >> Glen Barber writes: > >> > >>> Modified: head/lib/clang/llvm.build.mk > >>> ============================================================================== > >>> --- head/lib/clang/llvm.build.mk Fri Oct 19 00:24:23 2018 (r339435) > >>> +++ head/lib/clang/llvm.build.mk Fri Oct 19 00:37:47 2018 (r339436) > >>> @@ -17,7 +17,7 @@ CFLAGS+= -I${LLVM_SRCS}/include > >>> CFLAGS+= -DLLVM_BUILD_GLOBAL_ISEL > >>> CFLAGS+= -D__STDC_LIMIT_MACROS > >>> CFLAGS+= -D__STDC_CONSTANT_MACROS > >>> -#CFLAGS+= -DNDEBUG > >>> +CFLAGS+= -DNDEBUG > >> > >> Would Clang still hit asserts instead of crashing with cryptic messages? > > > > In llvm, assertions (and various other internal consistency checks) are > > turned off by defining NDEBUG. So indeed, if something in the internal > > state goes in an unexpected direction, you could get crashes or other > > "interesting" effects. > > > > That said, the resulting executable(s) should run somewhat faster, and > > be somewhat smaller. I think we have always done this for stable > > branches and releases. > > But this commit is for -CURRENT, not -STABLE or -RELEASE. With hat RE: It looks like this should be on the list of RE@ "Stable Branch Creation" check/change list that gets done by RE@ when a stable branch is created so that it is a early commit post branch and not a head commit that is merged post branch. I have forwarded a copy of this issue to internel re@ mail and we whall deal with it for stable/12 as an RE(implicit) commit, and this should probably be reverted from ^head at your descrition. Thanks, Rod > $ svn cat svn://svn.freebsd.org/base/stable/12/lib/clang/llvm.build.mk | fgrep NDEBUG ~ > #CFLAGS+= -DNDEBUG > > $ svn cat svn://svn.freebsd.org/base/releng/11.2/lib/clang/llvm.build.mk | fgrep NDEBUG > CFLAGS+= -DNDEBUG > > > > > If users encounter such crashes, it will still write reproduction files > > (self-contained .c or .cpp file and a shell script), so those can be > > included in bug reports, and run on a copy of clang with assertions. > > > > -Dimitry -- Rod Grimes rgrimes@freebsd.org