Date: Thu, 22 Apr 2021 10:07:58 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 5b7c17856512 - main - git hooks: Rework authorship instructions. Message-ID: <YIFK/tIpcfqWTWVh@FreeBSD.org> In-Reply-To: <202104220952.13M9qJNE092982@gitrepo.freebsd.org> References: <202104220952.13M9qJNE092982@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 22, 2021 at 09:52:19AM +0000, Mathieu Arnold wrote:
> ...
> diff --git a/.hooks/prepare-commit-msg b/.hooks/prepare-commit-msg
> @@ -44,6 +44,9 @@ $(awk '1;/^#$/{exit}' "$1")
> # <then a blank line>
> # 72 columns --|
> #
> +# Do not add a Submitted by line. If someone besides the committer sent in the
> +# change, the commit author should be set using \`git commit --author\`.
> +#
This doesn't seem right. "Submitted by" can be a list, not a single name.
Also, I rarely commit submitted work verbatim, so technically the author
is me 99% of the time, yet it would be appropriate to give attribution to
the original submitter, esp. if there is no PR number (private submission).
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YIFK/tIpcfqWTWVh>