From owner-cvs-all Sat Apr 6 19: 4:32 2002 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 7970437B404; Sat, 6 Apr 2002 19:04:29 -0800 (PST) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.2/8.12.2) with ESMTP id g3734SYm000193; Sat, 6 Apr 2002 19:04:28 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.2/8.12.2/Submit) id g3733CEs000173; Sat, 6 Apr 2002 19:03:12 -0800 (PST) Date: Sat, 6 Apr 2002 19:03:12 -0800 From: "David O'Brien" To: Bruce Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys cdefs.h Message-ID: <20020406190312.A99957@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <200204062057.g36Kv3n69228@freefall.freebsd.org> <20020407124346.R544-100000@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20020407124346.R544-100000@gamplex.bde.org>; from bde@zeta.org.au on Sun, Apr 07, 2002 at 12:48:29PM +1000 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Apr 07, 2002 at 12:48:29PM +1000, Bruce Evans wrote: > > Log: > > Add __SCCSID. And add the NO__SCCSID, NO__RCSID, NO__RCSID_SOURCE, and > > NO__COPYRIGHT knobs to more easily deal with imported vendor sources. > > Please back this out and don't change anything to use it. I will back > out the mistake that added __RCSID() similarly. There is no end to > adding cruft to support unportable macros in foreign sources. Just > ifdef the unportable macro invocations or remove them. Ones with > vendor ids must not be removed of course. I do not see what is so bad about these knobs. They occur for us by the hundreds. Before removing these things, how do you propose to solve the issue they solve? We do not need 100 netbsd.h's, openbsd.h's, csrg.h's scattered around the source tree, each with a slightly different implementation? Are you agreeable to /usr/include/scm.h then? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message