From owner-freebsd-stable@FreeBSD.ORG Fri May 24 08:21:34 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id C1FC1A8F; Fri, 24 May 2013 08:21:34 +0000 (UTC) (envelope-from spork@bway.net) Received: from smtp1.bway.net (smtp1.bway.net [216.220.96.27]) by mx1.freebsd.org (Postfix) with ESMTP id 8076E83D; Fri, 24 May 2013 08:21:34 +0000 (UTC) Received: from frankentosh.sporklab.com (foon.sporktines.com [96.57.144.66]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: spork@bway.net) by smtp1.bway.net (Postfix) with ESMTPSA id 62D0395854; Fri, 24 May 2013 04:21:33 -0400 (EDT) Subject: Re: Apparent fxp regression in FreeBSD 8.4-RC3 Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset=windows-1252 From: Charles Sprickman In-Reply-To: <20130524054720.GA1496@michelle.cdnetworks.com> Date: Fri, 24 May 2013 04:21:32 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <1C316A6C-7285-4178-B325-8A905E277342@bway.net> References: <20130524010943.GA37252@icarus.home.lan> <20130524012117.GE1672@glenbarber.us> <20130524030351.GA39091@icarus.home.lan> <20130524031303.GC28865@glenbarber.us> <20130524033806.GA39720@icarus.home.lan> <20130524034244.GD28865@glenbarber.us> <20130524044035.GA40957@icarus.home.lan> <20130524044919.GA41292@icarus.home.lan> <20130524054720.GA1496@michelle.cdnetworks.com> To: pyunyh@gmail.com X-Mailer: Apple Mail (2.1085) Cc: Jeremy Chadwick , Glen Barber , freebsd-stable@freebsd.org, FreeBSD Release Engineering Team X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 May 2013 08:21:34 -0000 On May 24, 2013, at 1:47 AM, YongHyeon PYUN wrote: > On Thu, May 23, 2013 at 09:49:19PM -0700, Jeremy Chadwick wrote: >> On Thu, May 23, 2013 at 09:40:35PM -0700, Jeremy Chadwick wrote: >>> On Thu, May 23, 2013 at 11:42:44PM -0400, Glen Barber wrote: >>>> On Thu, May 23, 2013 at 08:38:06PM -0700, Jeremy Chadwick wrote: >>>>> If someone wants me to test DHCP via fxp(4) on the above system (I = can >>>>> do so with both NICs), just let me know; it should only take me = half an >>>>> hour or so. >>>>>=20 >>>>> I'll politely wait for someone to say "please do so" else won't = bother. >>>>>=20 >>>>=20 >>>> For the sake of completeness... >>>>=20 >>>> "Please do so." :) >>>=20 >>> Issue reproduced 100% reliably, even within sysinstall. >>>=20 >>> {snip}=20 >>=20 >> Forgot to add: >>=20 >> This issue ONLY happens when using DHCP. >>=20 >> Statically assigning the IP address works fine; fxp0 goes down once, >> up once, then stays up indefinitely. >=20 > I asked Mike to try backing out dhclient(8) change(r247336) but it > seems he missed that. Jeremy, could you try that? >=20 > I guess dhclient(8) does not like flow-control negotiation of > fxp(4) after link establishment. Confirmed here that removing the linkstate stuff from r247336 fixes it. Before: May 24 08:00:17 fxptest dhclient: New Subnet Mask (fxp0): 255.255.255.0 May 24 08:00:17 fxptest dhclient: New Broadcast Address (fxp0): = 10.3.2.255 May 24 08:00:17 fxptest dhclient: New Routers (fxp0): 10.3.2.1 May 24 08:00:19 fxptest kernel: fxp0: link state changed to UP May 24 08:00:19 fxptest kernel: fxp0: link state changed to DOWN May 24 08:00:19 fxptest dhclient: New IP Address (fxp0): 10.3.2.109 May 24 08:00:19 fxptest dhclient: New Subnet Mask (fxp0): 255.255.255.0 May 24 08:00:19 fxptest dhclient: New Broadcast Address (fxp0): = 10.3.2.255 May 24 08:00:19 fxptest dhclient: New Routers (fxp0): 10.3.2.1 May 24 08:00:21 fxptest kernel: fxp0: link state changed to UP May 24 08:00:21 fxptest dhclient: New IP Address (fxp0): 10.3.2.109 May 24 08:00:21 fxptest kernel: fxp0: link state changed to DOWN May 24 08:00:21 fxptest dhclient: New Subnet Mask (fxp0): 255.255.255.0 May 24 08:00:21 fxptest dhclient: New Broadcast Address (fxp0): = 10.3.2.255 May 24 08:00:21 fxptest dhclient: New Routers (fxp0): 10.3.2.1 May 24 08:00:23 fxptest kernel: fxp0: link state changed to UP May 24 08:00:23 fxptest dhclient: New IP Address (fxp0): 10.3.2.109 May 24 08:00:23 fxptest kernel: fxp0: link state changed to DOWN After: May 24 08:07:05 fxptest kernel: fxp0: link state changed to DOWN May 24 08:07:07 fxptest kernel: fxp0: link state changed to UP May 24 08:07:12 fxptest dhclient: New IP Address (fxp0): 10.3.2.109 May 24 08:07:12 fxptest kernel: fxp0: link state changed to DOWN May 24 08:07:12 fxptest dhclient: New Subnet Mask (fxp0): 255.255.255.0 May 24 08:07:12 fxptest dhclient: New Broadcast Address (fxp0): = 10.3.2.255 May 24 08:07:12 fxptest dhclient: New Routers (fxp0): 10.3.2.1 May 24 08:07:14 fxptest kernel: fxp0: link state changed to UP root@fxptest:/usr/home/spork # date Fri May 24 08:10:32 UTC 2013 Note there is still a down/up/down/up transition on starting dhclient=85 Am I correct that the linkstate changes are meant to allow for an = automatic retry for a lease when the ethernet connection is dropped? = That doesn't seem wrong, it just seems like somewhere we should be = waiting a few seconds. It appears that each time dhclient gets a lease, = even without the linkstate code, the connection briefly drops=85' Charles=