Date: Thu, 9 Jan 2020 12:59:37 -0800 From: Conrad Meyer <cem@freebsd.org> To: Mark Johnston <markj@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r356569 - head/lib/libc/locale Message-ID: <CAG6CVpXbGLc4QHQMLN6bPM8-fj%2BzNrWbiTkMvSnfS2h5Hqz%2BaQ@mail.gmail.com> In-Reply-To: <202001092049.009KnQPE069028@repo.freebsd.org> References: <202001092049.009KnQPE069028@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 9, 2020 at 12:49 Mark Johnston <markj@freebsd.org> wrote: > Author: markj > Date: Thu Jan 9 20:49:26 2020 > New Revision: 356569 > URL: https://svnweb.freebsd.org/changeset/base/356569 > > Log: > libc: Fix a few bugs in the xlocale collation code. > > - Fix checks for mmap() failures. [1] > - Set the "map" and "maplen" fields of struct xlocale_collate so that > the table destructor actually does something. > - Free an already-mapped collation file before loading a new one into > the global table. > - Harmonize the prototype and definition of __collate_load_tables_l() by > adding the "static" qualifier to the latter. > > PR: 243195 > Reported by: cem [1] I appreciate the mention for my small role in this but the majority of the credit (PR report and solid initial diagnosis) should go to Koichi Murase <myoga.murase AT gmail.com>. Best, Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpXbGLc4QHQMLN6bPM8-fj%2BzNrWbiTkMvSnfS2h5Hqz%2BaQ>