From owner-freebsd-ports@FreeBSD.ORG Wed Jun 1 14:25:14 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 044B01065675 for ; Wed, 1 Jun 2011 14:25:14 +0000 (UTC) (envelope-from matthias.andree@gmx.de) Received: from mailout-de.gmx.net (mailout-de.gmx.net [213.165.64.22]) by mx1.freebsd.org (Postfix) with SMTP id 6B6018FC1E for ; Wed, 1 Jun 2011 14:25:13 +0000 (UTC) Received: (qmail invoked by alias); 01 Jun 2011 14:25:12 -0000 Received: from dtmd-4db20450.pool.mediaWays.net (EHLO [192.168.178.23]) [77.178.4.80] by mail.gmx.net (mp008) with SMTP; 01 Jun 2011 16:25:12 +0200 X-Authenticated: #428038 X-Provags-ID: V01U2FsdGVkX18m31UtR5wm2zhb5QgQTB6r4Zml6hf3qqscreHjh5 R22mYZ0TE7gOMd Message-ID: <4DE64BC7.5040804@gmx.de> Date: Wed, 01 Jun 2011 16:25:11 +0200 From: Matthias Andree User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110424 Thunderbird/3.1.10 MIME-Version: 1.0 To: freebsd-ports@freebsd.org References: <4DE5D8C9.3020506@icyb.net.ua> <4DE6244E.1040301@FreeBSD.org> <20110601114442.GB2223@reindeer.exwg.net> <4DE6392D.5000106@gmx.de> <20110601131956.GC2223@reindeer.exwg.net> <4DE64546.7070604@FreeBSD.org> In-Reply-To: <4DE64546.7070604@FreeBSD.org> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 Cc: bapt@freebsd.org, amatus@gnu.org Subject: Re: lang/guile build fails for me X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2011 14:25:14 -0000 Am 01.06.2011 15:57, schrieb Andriy Gapon: > on 01/06/2011 16:19 Christoph Moench-Tegeder said the following: >> Ah, yes, LDFLAGS. The port's Makefile already has >> LDFLAGS="-L${LOCALBASE}/lib" in $CONFIGURE_ENV, and as guile's configure > > BTW, I think that CONFIGURE_ENV in the port's Makefile better be set with +=, for > safety. Sure, but that doesn't help if you add new varname=value assignments for the same varname - these aren't cumulative as you've shown. >> is a standard autoconf configure, $LDFLAGS should be picked up (the >> output of "./configure --help" supports this), but... well, it isn't. > > Looks like LDFLAGS are lost from the environment before configure is run: > ac_cv_env_LDFLAGS_set=set > ac_cv_env_LDFLAGS_value=' -rpath=/usr/lib:/usr/local/lib' > > And given the USE_NCURSES workaround posted in this thread, that takes to > Mk/bsd.ncurses.mk where we have: > ... > NCURSES_LDFLAGS+= -rpath=${NCURSESRPATH} > > .if defined(LDFLAGS) > LDFLAGS+=${NCURSES_LDFLAGS} > .else > LDFLAGS=${NCURSES_LDFLAGS} > .endif > > CONFIGURE_ENV+= LDFLAGS="${LDFLAGS}" > ... > > I think that the above line overrides whatever is set in the port's Makefile. Plausible - because there would be two different LDFLAGS="mumble" options in CONFIGURE_ENV, can you check that? make -V CONFIGURE_ENV or make -n do-configure should reveal that. Note that LDFLAGS isn't used by bsd.port.mk itself, in contrast to CPPFLAGS, so that ports can't be expected to set this variable either. That makes bsd.ncurses.mk incompatible with a few more ports than just guile I suppose... Cc'ing bapt@. It appears diligent to look at all ports that set USE_NCURSES. (Still the other observed port inconsistencies should get fixed, too.) -- Matthias Andree