From owner-freebsd-current@FreeBSD.ORG Sun Jul 31 13:57:07 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1E88D1065670; Sun, 31 Jul 2011 13:57:07 +0000 (UTC) (envelope-from uqs@spoerlein.net) Received: from acme.spoerlein.net (acme.spoerlein.net [IPv6:2a01:4f8:131:23c2::1]) by mx1.freebsd.org (Postfix) with ESMTP id A34EE8FC0C; Sun, 31 Jul 2011 13:57:06 +0000 (UTC) Received: from localhost (acme.spoerlein.net [IPv6:2a01:4f8:131:23c2::1]) by acme.spoerlein.net (8.14.4/8.14.4) with ESMTP id p6VDv1xH055009 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 31 Jul 2011 15:57:01 +0200 (CEST) (envelope-from uqs@spoerlein.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=spoerlein.net; s=dkim200908; t=1312120621; bh=p1Tlvo8VsEb2Rfj8HwRRryN/yP8aDEj9LVWsAVcATLc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=mvSev+wpcxqrCjyfmRGVEqy0Yn6OsNs6AXioXvuQPJiioG9jYAjYF3GHVO06mGdYS PfKl/bbGL6X+5nO9YGYpE02det97SYiCluNUSbY7EZfrJWZ7yayQPH5an045Zb023G 1mEmBoruglZhLsg3/L6r2q+6DKChNb8GY3V/0St8= Date: Sun, 31 Jul 2011 15:57:01 +0200 From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= To: d@delphij.net Message-ID: <20110731135700.GC11991@acme.spoerlein.net> Mail-Followup-To: d@delphij.net, ru@freebsd.org, FreeBSD Current References: <4E3510CC.8090300@delphij.net> <20110731121732.GB11991@acme.spoerlein.net> <4E354DFB.1020206@delphij.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Qbvjkv9qwOGw/5Fx" Content-Disposition: inline In-Reply-To: <4E354DFB.1020206@delphij.net> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: FreeBSD Current Subject: Re: weekly_catman not generating the right result? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jul 2011 13:57:07 -0000 --Qbvjkv9qwOGw/5Fx Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, 2011-07-31 at 05:43:39 -0700, Xin LI wrote: > On 07/31/11 05:17, Ulrich Sp=C3=B6rlein wrote: > > On Sun, 2011-07-31 at 01:22:36 -0700, Xin LI wrote: > >> Hi, > >>=20 > >> I just noticed that weekly_catman is not generating the right > >> result, e.g. instead of a highlight NAME, it gives 1mNAME0m (looks > >> like the escape character is missing here). > >>=20 > >> Is this a known issue? > >=20 > > Now it is :) > >=20 > > This is due to the recent changes that made groff emit ANSI > > sequences and catman(1) is still putting col(1) in the pipe, which is > > not really required and gobbles up part of the escape sequences. > >=20 > > Please try the attached patch. Thanks. >=20 > Thanks, that fixes the problem. >=20 > Note that I noticed that setting PAGER to less won't work. Looking at > my 8.2-RELEASE system, the rendered catpages are using ^H when > highlighting while on -CURRENT it's an escape sequence (but I didn't see > any change to nroff script nor catman itself)... The change that did this is r222648. You'll need to use `less -Rs' as your PAGER/MANPAGER (or export LESS=3D-Rs). It's debatable if we want catpages to retain the old way of marking up bold and underlined text. Ruslan: bsd.doc.mk was told to not use SGR in r222647, does it make sense to do the same for catpages? Uli --Qbvjkv9qwOGw/5Fx Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iQEcBAEBAgAGBQJONV8sAAoJEKOmmGRKr4LOAekH/3VTFQripKzPjS53zyodDWnF vfrlPefG3ve6mYHWmx2DfOrrGWljBEIFr0sNhU/sR8mqpqXem8AIFzvqjwdyM3jv 5jb2bUK4nnR0lNjDDqrFScKZZXa3c/mpXfF+0tXqMjnIw6blPXEbsRYdJgCEufyR LyWVazWS6cBVCORwQx2qrPmXJ4FRcDPHnlELcuFmUG8Esein1Jwfotb8TzU34VVO gWHyz2RTuxaCc0Qu1IME2mEpAv8Y8CXSQO/3Py8s59PjxWyPc1RkTlbGHlbOi6aR 4OMmLdTW2RAOU57JvBUFuSJ8QBEX+6YSbijIwZnt9fqKu+vAF1mty3E4Id35vCc= =PcJO -----END PGP SIGNATURE----- --Qbvjkv9qwOGw/5Fx--