From owner-freebsd-mobile@FreeBSD.ORG Fri Apr 2 07:25:55 2004 Return-Path: Delivered-To: freebsd-mobile@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 80CA916A4CE; Fri, 2 Apr 2004 07:25:55 -0800 (PST) Received: from smtp.newipnet.com (5.Red-80-32-157.pooles.rima-tde.net [80.32.157.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6700643D1F; Fri, 2 Apr 2004 07:25:54 -0800 (PST) (envelope-from freebsd@newipnet.com) Received: by smtp.newipnet.com (ESMTP Server, from userid 511) id 6EDD4204DB; Fri, 2 Apr 2004 17:25:51 +0200 (CEST) Received: from madre (madre.newipnet.com [192.168.128.4]) by smtp.newipnet.com (ESMTP Server) with ESMTP id 7866A204FC; Fri, 2 Apr 2004 17:25:45 +0200 (CEST) Message-ID: <200404021724400672.31B8DBC9@192.168.128.16> X-Mailer: Courier 3.50.00.09.1092 (http://www.rosecitysoftware.com) (P) Date: Fri, 02 Apr 2004 17:24:40 +0200 From: "Carlos Velasco" To: freebsd-current@freebsd.org Content-Type: text/plain; charset="ISO-8859-1" X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on atlas.newipnet.com X-Spam-Level: X-Spam-Status: No, hits=-104.9 required=5.0 tests=BAYES_00,USER_IN_WHITELIST autolearn=ham version=2.63 cc: shibagaki.takeshi@renesas.com cc: freebsd-mobile@freebsd.org Subject: [patch] Xircom REM56G-100 X-BeenThere: freebsd-mobile@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Mobile computing with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Apr 2004 15:25:55 -0000 Hello, Here's a patch for Xircom Ethernet cards REM56G and I think CEM56 to work (Realports). There's a problem in the current driver that prevent these cards to work failing with errors: xe0: Cannot allocate ioport device_probe_and_attach: xe0 attach returned 12 It fails in OLDCARD and NEWCARD, as the problem is in the driver. Problem is related to a simple error in a for. --- xe/if_xe_pccard.c Fri Apr 2 17:13:37 2004 +++ xenew/if_xe_pccard.c Fri Apr 2 17:14:52 2004 @@ -271,7 +271,7 @@ scp->card_type = card_itm->card_type_desc; if (card_itm->prod_type & XE_PROD_MODEM_UMASK) scp->modem = 1; - for(i=1; i!=XE_CARD_TYPE_FLAGS_DINGO; i=i<<1) { + for(i=1; i<=XE_CARD_TYPE_FLAGS_DINGO; i=i<<1) { switch(i & card_itm->flags) { case XE_CARD_TYPE_FLAGS_CE2: scp->ce2 = 1; break; Regards, Carlos Velasco