From owner-freebsd-ports-bugs  Sun Mar  2 23:15:20 2003
Delivered-To: freebsd-ports-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1D52C37B401; Sun,  2 Mar 2003 23:15:19 -0800 (PST)
Received: from net2.dinoex.sub.org (net2.dinoex.sub.org [212.184.201.182])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D787643FAF; Sun,  2 Mar 2003 23:15:16 -0800 (PST)
	(envelope-from dirk.meyer@dinoex.sub.org)
Received: from net2.dinoex.sub.org (dinoex@net2.dinoex.de [212.184.201.182])
	by net2.dinoex.sub.org (8.12.6/8.12.6) with ESMTP id h237F5BH003214;
	Mon, 3 Mar 2003 08:15:07 +0100 (CET)
	(envelope-from dirk.meyer@dinoex.sub.org)
X-Authentication-Warning: net2.dinoex.sub.org: Host dinoex@net2.dinoex.de [212.184.201.182] claimed to be net2.dinoex.sub.org
Received: from gate.dinoex.sub.org (dinoex@localhost)
	by net2.dinoex.sub.org (8.12.6/8.12.6/Submit) with BSMTP id h237F4ad003201;
	Mon, 3 Mar 2003 08:15:04 +0100 (CET)
	(envelope-from dirk.meyer@dinoex.sub.org)
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.ORG
Message-ID: <48Jp/BjOJm@dmeyer.dinoex.sub.org>
From: dirk.meyer@dinoex.sub.org (Dirk Meyer)
Organization: privat
Subject: Re: ports/48860: wrong dependency in bsd.port.mk
Date: Mon, 03 Mar 2003 08:11:07 +0100
X-Mailer: Dinoex 1.79
References: <200303030558.h235wId8090437@freefall.freebsd.org> <200303030558.h235wId8090437@freefall.freebsd.org> <20030303060207.GB34662@rot13.obsecurity.org>
X-Gateway: ZCONNECT gate.dinoex.sub.org [UNIX/Connect 0.94]
X-Accept-Language: de,en
X-PGP-Fingerprint: 44 16 EC 0A D3 3A 4F 28  8A 8A 47 93 F1 CF
	2F 12
X-Noad: Please don't send me ad's by mail.  I'm bored by this
	type of mail.
X-Copyright: (C) Copyright 2001 by Dirk Meyer -- All rights reserved.
X-Note: sending SPAM is a violation of both german and US law
	and will at least trigger a complaint at your provider's
	postmaster.
X-PGP-Key-Avail: mailto:pgp-public-keys@keys.de.pgp.net Subject:GET
	0x331CDA5D
X-No-Archive: yes
X-ZC-VIA: 20030303000000W+1@dinoex.sub.org
Sender: owner-freebsd-ports-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports-bugs>
X-Loop: FreeBSD.org

Kris Kennaway schrieb:,

> +.if ${PATCHFILES:M*.bz2}x != x && !exists(/usr/bin/bzip2)
> 
> This is incorrect and should use an OSVERSION test instead of
> existence of a local file.

well everywhere else it uses "exists" too:
so it is the same check as in the other sections:

$ grep bzip2 /usr/ports/Mk/bsd.port.mk
# USE_BZIP2             - Says that the port tarballs use bzip2, not gzip, for
# EXTRACT_CMD   - Command for extracting archive (default: "bzip2" if
.if exists(/usr/bin/bzip2)
BZIP2_CMD?=     /usr/bin/bzip2
BZIP2_CMD?=     ${LOCALBASE}/bin/bzip2
PATCH_DEPENDS+=         bzip2:${PORTSDIR}/archivers/bzip2
.if defined(USE_BZIP2) && !exists(/usr/bin/bzip2)
EXTRACT_DEPENDS+=       bzip2:${PORTSDIR}/archivers/bzip2

kind regards Dirk

- Dirk Meyer, Im Grund 4, 34317 Habichtswald, Germany
- [dirk.meyer@dinoex.sub.org],[dirk.meyer@guug.de],[dinoex@FreeBSD.org]

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports-bugs" in the body of the message