From owner-freebsd-standards@freebsd.org Sun Jul 30 22:08:56 2017 Return-Path: Delivered-To: freebsd-standards@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CFDD8DC3640 for ; Sun, 30 Jul 2017 22:08:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B629A82841 for ; Sun, 30 Jul 2017 22:08:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v6UM8uke066200 for ; Sun, 30 Jul 2017 22:08:56 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-standards@FreeBSD.org Subject: [Bug 220587] /bin/sh Incorrect options handling Date: Sun, 30 Jul 2017 22:08:56 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: jilles@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-standards@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2017 22:08:56 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220587 --- Comment #5 from Jilles Tjoelker --- I think this is the right direction but I do have some things that need to = be changed. So that installworld does not fail, the new directory should be added to the appropriate file in etc/mtree/ (BSD.tests.dist in this case). Perhaps it sh= ould be named "invocation" instead of "options", since tests for a few set optio= ns are under "execution" already. Also, I would like this split up in two patches, one that adds some testcas= es that already work (and will not be broken by the change) and one that fixes= the bug and adds testcases that fail with the previous version. The variable saw_minus_c would be more consistently named cflag. I suppose = it is OK to start using at this point. A -c without a command_string operand (as in "sh -c" or "sh -c -s") should = not be ignored, since this causes commands to be read from unexpected sources. (This is one situation for a testcase that already passes.) The current code also rejects -cc, even if a command_string operand is give= n. Accepting this, as your patch does, seems consistent with other shells. The -f option is better suited than the -m option as a "dummy" option since= -m may cause the shell to stop itself in certain situations. The -a option is = also suitable. I like to be able to run testcases with various other shells, where possibl= e. To help with this, avoid echoing things starting with '-' or containing '\'= and do not assume that $- contains only the expected characters in the order sh currently happens to put them. For example, ${SH} -f -c -a 'echo $-:$0:$@' -foo -bar | grep -qx "fa:-foo:-bar" could be fixed as case `${SH} -f -c -a 'echo $-:$-:$0:$@' -foo -bar` in *f*:*a*:-foo:-bar) : ;; *) echo bad ;; esac (I have not used $() here since shells/heirloom-sh may pass a few related tests, even though it will not pass this one.) --=20 You are receiving this mail because: You are the assignee for the bug.=