From owner-cvs-all Sat Mar 23 14:30:53 2002 Delivered-To: cvs-all@freebsd.org Received: from rover.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id C501A37B427; Sat, 23 Mar 2002 14:30:22 -0800 (PST) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.3/8.11.3) with ESMTP id g2NMULi97885; Sat, 23 Mar 2002 15:30:21 -0700 (MST) (envelope-from imp@village.org) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.11.6/8.11.6) with ESMTP id g2NMUKL36617; Sat, 23 Mar 2002 15:30:20 -0700 (MST) (envelope-from imp@village.org) Date: Sat, 23 Mar 2002 15:29:58 -0700 (MST) Message-Id: <20020323.152958.99178604.imp@village.org> To: obrien@FreeBSD.org Cc: bde@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys bio.h conf.h disklabel.h diskslice.h event.h file.h filedesc.h libkern.h malloc.h mount.h msgbuf.h protosw.h socketvar.h sysent.h systm.h From: "M. Warner Losh" In-Reply-To: <20020323123015.A861@dragon.nuxi.com> References: <200203230846.g2N8kqk91906@freefall.freebsd.org> <20020323123015.A861@dragon.nuxi.com> X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <20020323123015.A861@dragon.nuxi.com> "David O'Brien" writes: : On Sat, Mar 23, 2002 at 12:46:52AM -0800, Bruce Evans wrote: : > Modified files: : > sys/sys bio.h conf.h disklabel.h diskslice.h : > event.h file.h filedesc.h libkern.h : > malloc.h mount.h msgbuf.h protosw.h : > socketvar.h sysent.h systm.h : > Log: : > Fixed some style bugs in the removal of __P(()). The main ones were : > not removing tabs before "__P((", and not outdenting continuation lines : > to preserve non-KNF lining up of code with parentheses. Switch to KNF : > formatting and/or rewrap the whole prototype in some cases. : : According to style(9) you have not KNF'ed the prototypes. : Applicable example: : : static char *function(int _arg, const char *_arg2, struct foo *_arg3, : struct bar *_arg4); Is this because he left some functions with "emacs-style" indentation: static char *function(int _arg, const char *_arg2, struct foo *_arg3, struct bar *_arg4); Or some other reason? There are so many files that it is hard to know what you are talking about for sure... Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message