From owner-freebsd-audit Tue Oct 24 12:18:19 2000 Delivered-To: freebsd-audit@freebsd.org Received: from rover.village.org (rover.village.org [204.144.255.49]) by hub.freebsd.org (Postfix) with ESMTP id D4CEE37B4CF for ; Tue, 24 Oct 2000 12:18:16 -0700 (PDT) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.0/8.11.0) with ESMTP id e9OJIEn88131; Tue, 24 Oct 2000 13:18:15 -0600 (MDT) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id NAA18110; Tue, 24 Oct 2000 13:18:14 -0600 (MDT) Message-Id: <200010241918.NAA18110@harmony.village.org> To: Joachim =?iso-8859-1?Q?Str=F6mbergson?= Subject: Re: Which mktemp()s are bad? Cc: FreeBSD-Audit In-reply-to: Your message of "Tue, 24 Oct 2000 21:16:07 +0200." <39F5DFF7.8ABBAA99@ludd.luth.se> References: <39F5DFF7.8ABBAA99@ludd.luth.se> Date: Tue, 24 Oct 2000 13:18:14 -0600 From: Warner Losh Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <39F5DFF7.8ABBAA99@ludd.luth.se> Joachim =?iso-8859-1?Q?Str=F6mbergson?= writes: : I saw Joeroens posting on the mktemp() issue in printjob.c. During : buildworlds I have seen warnings about mktemp() being used if not : frequently, at least on quite a few places. This got me thinking - : Generally, are all mktemp() calls bad? Which are the one that *really* : should be eliminated? Can they all be emliminated? Generally speaking, they are all bad. However, there are some safe ones in the tree. It would hurt nothing to convert the safe ones to using mkstemp, modulo repository issues. : I did some grepping on the Stable tree as of 2000-10-24 and found a few : places where mktemp was used, though mostly in contributed stuff, like : GNU binutils. : : (Side note: Should those be fixed for FreeBSD or feedbacked to the : respective team at FSF?) Yes. But likely the pain of doing it in the tree is too large for David O'Brien to want to deal with. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message