Date: Sun, 16 Jan 2011 15:42:47 +0100 From: Marius Strobl <marius@alchemy.franken.de> To: Lev Serebryakov <lev@serebryakov.spb.ru> Cc: Pyun YongHyeon <pyunyh@gmail.com>, freebsd-net@freebsd.org Subject: Re: [patch] re(4) problems on networks with disabled autonegotiation "solver" (WAS: Juniper e3k with ports limitied to...) -- REQUEST FOR REVIEW Message-ID: <20110116144247.GA65399@alchemy.franken.de> In-Reply-To: <178613186.20110114134109@serebryakov.spb.ru> References: <36074996.20110112192009@serebryakov.spb.ru> <20110112213208.GD12920@michelle.cdnetworks.com> <20110112225907.GA44318@alchemy.franken.de> <20110113173925.GA49356@alchemy.franken.de> <20110113212713.GC17502@michelle.cdnetworks.com> <20110114012412.GK97101@alchemy.franken.de> <178613186.20110114134109@serebryakov.spb.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 14, 2011 at 01:41:09PM +0300, Lev Serebryakov wrote: > Hello, Marius. > You wrote 14 ?????? 2011 ?., 4:24:12: > > > found by ignoring the bits set in the "don't care mask". I've > > updated the patch at the above URL accordingly and based on my > > testing it now should actually work as expected. Sorry for the > > glitch. > Yes, it works for me. Thanks for testing! I've committed the patch to HEAD and will try to get it into 7.4 and 8.2. > Only one note: I think, it is good idea to document this flag in > re(4). > Technically re.4 obviously is the wrong location for documenting it as it's generally the business of the PHY drivers to handle the media. Moreover, rgephy(4) driven PHYs are also commonly used in combination with at least axe(4), nfe(4), nve(4) and sge(4) MACs so we would have to document this special media option in all of the corresponding man pages, which would introduce undesirable redundancy. So instead I've added a rgephy.4 man page and documented it there. Actually, this is a very good example for why we generally should not document media types and options in the man pages of MAC drivers that take advantage of mii(4) but instead add a common ifmedia.4 and just point there and if as in this case it makes sense to man pages of specific PHY drivers. Marius
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110116144247.GA65399>