From owner-svn-src-all@freebsd.org Thu Aug 8 21:29:34 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CCA59B3823; Thu, 8 Aug 2019 21:29:34 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 464M2k4xL8z4tSW; Thu, 8 Aug 2019 21:29:34 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-ot1-f43.google.com with SMTP id q20so124450684otl.0; Thu, 08 Aug 2019 14:29:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=9zHpbiguCj1Wvo8MSrdICwzUZTuUjI09Upu8gZLRLYk=; b=Lsnedcx3NwyAGelV/aSw9p210AOMN+yx0kgqI2buWztEBQBTBjxe3fIRn/74QgPmHQ rapZ4MdrIy7KUFvH70NrRkL1vrnnBjQHiRbOGAp+wFUGxfeWiZeyePE+5OjSktyG7LCS r1XiJ8+Pd3cmklBRD822a6N8gGTQcZhclACcz3eRo22qiQjZLDCk1IktrcDCL3CsSXJ+ s9CGM9AWV6GEi+JSPeS+9k2lAARllCztjEHtcKGFM/H6zxlyG7cdHKAxBJgJp+AY+oN5 cx2GN9Mt+AUJtHGSas+6zYccg0VlS6FQm/stcgii9QEKYeT3xbvXvu329Z7bXlcvYmgs WEVw== X-Gm-Message-State: APjAAAXQ501zFCx17e0lpjjt6BpItoPPA3HcuxQPsWyjqwjWS0XUcc0C rilPo8U2qsNhSrxMPRguVfQ6Uw9V X-Google-Smtp-Source: APXvYqwWDAI3EFFw4/eTjZ4JfZ2aBpnLne7/yrjZdFimFbSgmncPO5VMLY1d91c0QPBMrrqOv1OL6A== X-Received: by 2002:aca:4ad2:: with SMTP id x201mr4243929oia.129.1565299772167; Thu, 08 Aug 2019 14:29:32 -0700 (PDT) Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com. [209.85.210.42]) by smtp.gmail.com with ESMTPSA id 132sm31833716oid.47.2019.08.08.14.29.31 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 08 Aug 2019 14:29:31 -0700 (PDT) Received: by mail-ot1-f42.google.com with SMTP id n5so124658123otk.1; Thu, 08 Aug 2019 14:29:31 -0700 (PDT) X-Received: by 2002:a5d:8253:: with SMTP id n19mr6625806ioo.80.1565299771496; Thu, 08 Aug 2019 14:29:31 -0700 (PDT) MIME-Version: 1.0 References: <201908082009.x78K9bCV069231@repo.freebsd.org> In-Reply-To: <201908082009.x78K9bCV069231@repo.freebsd.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Thu, 8 Aug 2019 14:29:20 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r350778 - head/sys/contrib/zstd/lib/common To: Warner Losh Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 464M2k4xL8z4tSW X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.989,0]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Aug 2019 21:29:34 -0000 Thanks Warner for noticing and fixing this. I've sent the patch upstream to hopefully be addressed there as well: https://github.com/facebook/zstd/pull/1713 Best, Conrad On Thu, Aug 8, 2019 at 1:09 PM Warner Losh wrote: > > Author: imp > Date: Thu Aug 8 20:09:36 2019 > New Revision: 350778 > URL: https://svnweb.freebsd.org/changeset/base/350778 > > Log: > Stopgap fix for gcc platforms. > > Our in-tree gcc doesn't have a no-tree-vectorize optimization knob, so we get a > warning that it's unused. This causes the build to fail on all our gcc platforms. > Add a quick version check as a stop-gap measure to get CI building again. > > Modified: > head/sys/contrib/zstd/lib/common/compiler.h > > Modified: head/sys/contrib/zstd/lib/common/compiler.h > ============================================================================== > --- head/sys/contrib/zstd/lib/common/compiler.h Thu Aug 8 20:07:38 2019 (r350777) > +++ head/sys/contrib/zstd/lib/common/compiler.h Thu Aug 8 20:09:36 2019 (r350778) > @@ -128,7 +128,7 @@ > } > > /* vectorization */ > -#if !defined(__clang__) && defined(__GNUC__) > +#if !defined(__clang__) && defined(__GNUC__) && __GNUC__ > 5 > # define DONT_VECTORIZE __attribute__((optimize("no-tree-vectorize"))) > #else > # define DONT_VECTORIZE >