Date: Sun, 15 Jan 2017 14:14:55 +0100 From: Tijl Coosemans <tijl@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r431187 - in head/devel/dbus: . files Message-ID: <20170115141445.7b58a649@kalimero.tijl.coosemans.org> In-Reply-To: <20170114225816.zbx4lqxgof3zsfyq@ivaldir.etoilebsd.net> References: <201701111507.v0BF7sXr024443@repo.freebsd.org> <20170114225816.zbx4lqxgof3zsfyq@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 14 Jan 2017 23:58:16 +0100 Baptiste Daroussin <bapt@FreeBSD.org> wrote: > On Wed, Jan 11, 2017 at 03:07:54PM +0000, Tijl Coosemans wrote: >> -@dir /var/db/dbus >> +@dir /var/lib/dbus >> +@dir /var/lib >> @dir /var/run/dbus >> +@comment The following line may be removed after 2018-01-01 >> +@postexec [ -f /var/lib/dbus/machine-id -o ! -f /var/db/dbus/machine-id ] || cp -p /var/db/dbus/machine-id /var/lib/dbus/ > > :( > > I would have prefered a symlink rather this but hey (on FreeBSD /var/db > is the right place in theory :)) I'm really tired of FreeBSD putting files in different locations. It's just more work and no benefit. Pain without gain. The right place is whatever gives us, maintainers and users, the least amount of work. This is a balancing exercise between maintainers that need to maintain the hacks and patches and users that want to find certain files easily. So for documentation I'm all for moving that to a consistent location, but for runtime files /var/lib instead of /var/db is fine. For the same reason I also still think we should move libdata/pkgconfig to lib/pkgconfig. The pile of hacks and patches that could be removed from the ports tree is truly immense and no user would ever realise it or care about it. Just take a look at this oneliner, think about the work it could save us in the coming years and then please just commit it without hesitation :) Index: devel/pkgconf/Makefile =================================================================== --- devel/pkgconf/Makefile (revision 431371) +++ devel/pkgconf/Makefile (working copy) @@ -2,6 +2,7 @@ PORTNAME= pkgconf PORTVERSION= 1.1.1 +PORTREVISION= 1 CATEGORIES= devel MASTER_SITES= https://distfiles.dereferenced.org/pkgconf/ \ http://files.etoilebsd.net/pkgconf/ @@ -16,7 +17,7 @@ GNU_CONFIGURE= yes INSTALL_TARGET= install-strip USE_LDCONFIG= yes TEST_TARGET= check -CONFIGURE_ARGS= --with-pkg-config-dir=${PREFIX}/libdata/pkgconfig:/usr/libdata/pkgconfig \ +CONFIGURE_ARGS= --with-pkg-config-dir=${PREFIX}/lib/pkgconfig:${PREFIX}/libdata/pkgconfig:/usr/libdata/pkgconfig \ --with-system-libdir=/usr/lib \ --with-system-includedir=/usr/include MAKE_ARGS= MANDIR="${MAN1PREFIX}/man/man1"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170115141445.7b58a649>