Date: Wed, 28 Oct 2020 10:35:29 -1000 From: Romain =?iso-8859-1?Q?Tarti=E8re?= <romain@blogreen.org> To: Jan Beich <jbeich@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, greg@unrelenting.technology Subject: Re: svn commit: r553559 - in head/x11: . tilix Message-ID: <20201028203529.GA74398@blogreen.org> In-Reply-To: <7dra-i0ig-wny@FreeBSD.org> References: <202010281850.09SIocHR051975@repo.freebsd.org> <7dra-i0ig-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0OAP2g/MAC+5xKAE Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: svn commit: r553559 - in head/x11: . tilix On Wed, Oct 28, 2020 at 09:00:39PM +0100, Jan Beich wrote: > Romain Tarti=C3=A8re <romain@FreeBSD.org> writes: >=20 > > +PATCH_DIST_STRIP=3D-p1 > > +PATCH_SITES=3D https://patch-diff.githubusercontent.com/raw/gnunn1/til= ix/pull/ > > +PATCHFILES=3D 1733.diff >=20 > pull/1234.diff is a moving target. Better use commit hashes e.g., >=20 > PATCH_SITES=3D https://github.com/${GH_ACCOUNT}/${GH_PROJECT}/commit/ > PATCHFILES+=3D ce11b0bd936f.patch:-p1 # https://github.com/gnunn1/tilix/p= ull/1733 Good catch, this indeed makes sense! > > +BUILD_DEPENDS=3D ldc2:lang/ldc \ > > + po4a-translate:textproc/po4a \ > > + ${LOCALBASE}/libdata/pkgconfig/vted-3.pc:x11-toolkits/gtkd >=20 > Why not use shared libs like Alpine, Arch, Debian, Fedora, Void? > See https://github.com/DankBSD/ports/commit/2b892e4ea4aa Oh, I was not aware of this effort :-( ! I hapenned to find out some old WIP ports in my local ports directory, and saw that I could get everything to compile, so as these pieces where not in the FreeBSD ports tree I though it was worth it to push them=E2=80=A6 Building shared libs seems to require quite a lot of extra work but the author of these ports seems to have done all this. I added him in Cc (hey Greg!). Is there a reason for your ports x11-toolkits/gtkd-3 and x11/tilix _not_ being in the "official" FreeBSD ports tree? Do you have something to share regarding this point Jan made? Should we not better integrate _your_ ports in the FreeBSD ports tree and replace what I just committed? Would you be interested in being the maintainer of these ports? I am very sorry to reach you only now and would have been ways happier to be able to contact you before for talking about this! Thanks, Romain --=20 Romain Tarti=C3=A8re <romain@blogreen.org> http://romain.blogreen.or= g/ pgp: 8234 9A78 E7C0 B807 0B59 80FF BA4D 1D95 5112 336F (ID: 0x5112336F) (plain text =3Dnon-HTML=3D PGP/GPG encrypted/signed e-mail much appreciated) --0OAP2g/MAC+5xKAE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCAAdFiEEgjSaeOfAuAcLWYD/uk0dlVESM28FAl+Z1gsACgkQuk0dlVES M28oPwv/U7PGMEnI6FqNxlKmVi9EMOCRXn3lqHYfdIyyJYchXG53TfmjmkC6WzWJ jnq5Wd8AHc8AmbEwNXfXonrR1c4wyJymD5JkWIb7HactDXkhWEpPkkw2VFnuKhLs W7fcb+wIHDc5vH6zc4oyPDDwdFhtC/5h3BjO4Gpcp0f33+uWM1a9rfI74ZIgsJM1 /IoMFvNpEKERHYzni0r093xQCdEY5mNFtKo3g86GZJhFSSiFWejwbdSIWfN05oRL RcUsKDiUk8j+k0WQRsHxaSFREQq/ZhFr7TV5na4/ZQr6sTp/snbpcxHCQSgKOgn/ BIXI/bpE/FYqvLjlD1AdSSFmt8xSHZ3cKxL3Jxoecrr5YmMl4OOx57R1GPahCwIE BN4h/pr6TSzgaJNEmGou2Ee2za7kA5mLMZmPzZkm4hS6sgGyXj9NUca4yTdYDWg7 V99qQoPi4d/PejB00456b+2BTPQyWgXf/3efkvtuKlVOOk6eLYNDq/5ZAcYBdJzr Lv50rX22 =M4JZ -----END PGP SIGNATURE----- --0OAP2g/MAC+5xKAE--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20201028203529.GA74398>