From owner-svn-src-head@FreeBSD.ORG  Sun Aug  7 02:35:58 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 57745106564A;
	Sun,  7 Aug 2011 02:35:58 +0000 (UTC)
	(envelope-from marcel@xcllnt.net)
Received: from mail.xcllnt.net (mail.xcllnt.net [70.36.220.4])
	by mx1.freebsd.org (Postfix) with ESMTP id 215BF8FC08;
	Sun,  7 Aug 2011 02:35:57 +0000 (UTC)
Received: from dhcp-192-168-2-22.wifi.xcllnt.net (atm.xcllnt.net [70.36.220.6])
	(authenticated bits=0)
	by mail.xcllnt.net (8.14.5/8.14.5) with ESMTP id p772Zn6s008922
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);
	Sat, 6 Aug 2011 19:35:56 -0700 (PDT)
	(envelope-from marcel@xcllnt.net)
Mime-Version: 1.0 (Apple Message framework v1244.3)
Content-Type: text/plain; charset=us-ascii
From: Marcel Moolenaar <marcel@xcllnt.net>
In-Reply-To: <20110806232415.GE48988@alchemy.franken.de>
Date: Sat, 6 Aug 2011 19:35:49 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <96C6C36B-E521-4438-9AEF-59D9A922D3B4@xcllnt.net>
References: <201108061748.p76HmUbM061259@svn.freebsd.org>
	<4E3DA560.6020100@yandex.ru>
	<CAGH67wSFRXLRBVcoR8RME111pE7UaZ+y-k8qmTtCkOy+MC3Dhw@mail.gmail.com>
	<4E3DBAF8.5040102@FreeBSD.org>
	<20110806232415.GE48988@alchemy.franken.de>
To: Marius Strobl <marius@alchemy.franken.de>
X-Mailer: Apple Mail (2.1244.3)
Cc: src-committers@FreeBSD.org, Ruslan Mahmatkhanov <cvs-src@yandex.ru>,
	Garrett Cooper <yanegomi@gmail.com>, svn-src-all@FreeBSD.org,
	Andriy Gapon <avg@FreeBSD.org>, svn-src-head@FreeBSD.org
Subject: Re: svn commit: r224683 - head/lib/libthread_db
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Aug 2011 02:35:58 -0000


On Aug 6, 2011, at 4:24 PM, Marius Strobl wrote:

> On Sun, Aug 07, 2011 at 01:06:48AM +0300, Andriy Gapon wrote:
>> on 07/08/2011 00:41 Garrett Cooper said the following:
>>> It's not just i386. It's other architectures like arm, mips, and =
pc98
>>> according to the tinderbox reports (this list is potentially
>>> incomplete).
>>=20
>> Yeah, confusingly enough thr_pread_long() is declared to take =
uint64_t* as its
>> third argument, so this commit breaks all platforms where uint64_t is =
not
>> derived from (unsigned) long.
>> Just in case, thr_pread_int() takes uint32_t* as well.
>>=20
>=20
> Yes, the type of val is wrong. I'm currently running a fix through a
> universe build

Ah, euh, ok, I forgot about this particular quirk:

uint64_t is deliberate, because it's the width of long on 64-bit
architectures and thread_db is to be used as a support library
for a cross-tool (i.e. a 32-bit debugger for a 64-bit target).

That's why thr_pread_long() takes a pointer to uint64_t and
thr_pread_int() takes a pointer to uint32_t...

Sorry for missing this in the review.
FYI,

--=20
Marcel Moolenaar
marcel@xcllnt.net