From owner-freebsd-hackers  Wed Sep 11 10:56:53 2002
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8D5E737B400; Wed, 11 Sep 2002 10:56:50 -0700 (PDT)
Received: from obsecurity.dyndns.org (adsl-64-165-226-88.dsl.lsan03.pacbell.net [64.165.226.88])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 727FA43E42; Wed, 11 Sep 2002 10:56:49 -0700 (PDT)
	(envelope-from kris@obsecurity.org)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id 9356A66B62; Wed, 11 Sep 2002 10:56:48 -0700 (PDT)
Date: Wed, 11 Sep 2002 10:56:48 -0700
From: Kris Kennaway <kris@obsecurity.org>
To: David O'Brien <obrien@FreeBSD.ORG>
Cc: Kris Kennaway <kris@obsecurity.org>, Peter Wemm <peter@wemm.org>,
	Darren Pilgrim <dmp@pantherdragon.org>,
	Matthew Dillon <dillon@apollo.backplane.com>,
	Dan Nelson <dnelson@allantgroup.com>,
	Terry Lambert <tlambert2@mindspring.com>,
	Jason Andresen <jandrese@mitre.org>,
	Dmitry Morozovsky <marck@rinet.ru>, hackers@FreeBSD.ORG
Subject: Re: Updating bsd.cpu.mk (Re: -fomit-frame-pointer for the world build)
Message-ID: <20020911175648.GB96962@xor.obsecurity.org>
References: <3D50664F.71603B49@pantherdragon.org> <20020807015511.A1A092A7D6@canning.wemm.org> <20020906203026.GA78157@xor.obsecurity.org> <20020911044156.GB91353@dragon.nuxi.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="8P1HSweYDcXXzwPJ"
Content-Disposition: inline
In-Reply-To: <20020911044156.GB91353@dragon.nuxi.com>
User-Agent: Mutt/1.4i
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-hackers.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-hackers>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-hackers>
X-Loop: FreeBSD.ORG


--8P1HSweYDcXXzwPJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Sep 10, 2002 at 09:41:56PM -0700, David O'Brien wrote:

> +.  if ${CPUTYPE} == "athlon-mp" || ${CPUTYPE} == "athlon-xp" || ${CPUTYPE} == "athlon-4" || ${CPUTYPE} == "athlon"
> +_CPUCFLAGS = -march=${CPUTYPE}
>  .  elif ${CPUTYPE} == "k6-3"
>  _CPUCFLAGS = -march=k6-3
>  .  elif ${CPUTYPE} == "k6-2"

Why stop there?  Nearly all of the CPUTYPE values are the same as
their -march commands.

> +. if ${CPUTYPE} == "athlon-mp" || ${CPUTYPE} == "athlon-xp" || ${CPUTYPE} == "athlon-4"
> +MACHINE_CPU = athlon-xp k7 3dnow see mmx k6 k5 i586 i486 i386

                                    ^^^ typo

> +. elif ${CPUTYPE} == "athlon" || ${CPUTYPE} == "athlon-tbird"
> +MACHINE_CPU = athlon k7 3dnow mmx k6 k5 i586 i486 i386

Can you think of a situtation where the athlon/athlon-xp capabilities
would need to be tested?  i.e. what would they be used for?

Kris

--8P1HSweYDcXXzwPJ
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)

iD8DBQE9f4PfWry0BWjoQKURApB4AKCKsmJJO9uzkROoVg6EdkRNMWYIFgCgr3qT
50yNqP5zM2I7moKbfmx6DBU=
=Qgrh
-----END PGP SIGNATURE-----

--8P1HSweYDcXXzwPJ--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message