From owner-freebsd-bugs  Tue May 19 08:34:35 1998
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id IAA07980
          for freebsd-bugs-outgoing; Tue, 19 May 1998 08:34:35 -0700 (PDT)
          (envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id IAA07947
          for <freebsd-bugs@FreeBSD.org>; Tue, 19 May 1998 08:34:30 -0700 (PDT)
          (envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.8.8/8.8.5) id IAA00535;
	Tue, 19 May 1998 08:30:02 -0700 (PDT)
Received: from relay.ucb.crimea.ua (relay.ucb.crimea.ua [194.93.177.113])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id IAA06623
          for <FreeBSD-gnats-submit@freebsd.org>; Tue, 19 May 1998 08:29:15 -0700 (PDT)
          (envelope-from ru@ucb.crimea.ua)
Received: (from ru@localhost)
	by relay.ucb.crimea.ua (8.8.8/8.8.8) id SAA26629;
	Tue, 19 May 1998 18:28:46 +0300 (EEST)
	(envelope-from ru)
Message-Id: <199805191528.SAA26629@relay.ucb.crimea.ua>
Date: Tue, 19 May 1998 18:28:46 +0300 (EEST)
From: Ruslan Ermilov <ru@ucb.crimea.ua>
Reply-To: ru@ucb.crimea.ua
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: bin/6690: ppp doesn't close socket in CleanInterface()
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         6690
>Category:       bin
>Synopsis:       ppp doesn't close socket in CleanInterface()
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 19 08:30:02 PDT 1998
>Last-Modified:
>Originator:     Ruslan Ermilov
>Organization:
United Commercial Bank
>Release:        FreeBSD 2.2.6-STABLE i386
>Environment:

	-stable as of today

>Description:

	Socket is opened and not closed in CleanInterface()

>How-To-Repeat:

	Run ``ppp -direct'' (don't know if this affects other modes),
	and run ``fstat -p <pid>''.

>Fix:

	Apply the following patch:
	
Index: os.c
===================================================================
RCS file: /usr/FreeBSD-CVS/src/usr.sbin/ppp/os.c,v
retrieving revision 1.7.2.16
diff -u -r1.7.2.16 os.c
--- os.c	1998/01/26 20:05:04	1.7.2.16
+++ os.c	1998/05/19 15:15:53
@@ -183,6 +183,7 @@
         LogPrintf(LogERROR, "tun_configure: Can't get dst for %s on %s !\n",
                   inet_ntoa(((struct sockaddr_in *)&ifra.ifra_addr)->sin_addr),
                   name);
+      close(s);
       return 0;
     }
     ifra.ifra_broadaddr = ifrq.ifr_dstaddr;
@@ -191,10 +192,12 @@
         LogPrintf(LogERROR, "tun_configure: Can't delete %s address on %s !\n",
                   inet_ntoa(((struct sockaddr_in *)&ifra.ifra_addr)->sin_addr),
                   name);
+      close(s);
       return 0;
     }
   }
 
+  close(s);
   return 1;
 }
 
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message