From owner-cvs-all  Sat Apr  6 19:15:25 2002
Delivered-To: cvs-all@freebsd.org
Received: from espresso.q9media.com (espresso.q9media.com [216.254.138.122])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6DE1137B400; Sat,  6 Apr 2002 19:15:20 -0800 (PST)
Received: (from mike@localhost)
	by espresso.q9media.com (8.11.6/8.11.6) id g3738qZ41850;
	Sat, 6 Apr 2002 22:08:52 -0500 (EST)
	(envelope-from mike)
Date: Sat, 6 Apr 2002 22:08:52 -0500
From: Mike Barcroft <mike@FreeBSD.org>
To: "David O'Brien" <obrien@FreeBSD.org>
Cc: Bruce Evans <bde@zeta.org.au>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/sys cdefs.h
Message-ID: <20020406220852.F58485@espresso.q9media.com>
References: <200204062057.g36Kv3n69228@freefall.freebsd.org> <20020407124346.R544-100000@gamplex.bde.org> <20020406190312.A99957@dragon.nuxi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20020406190312.A99957@dragon.nuxi.com>; from obrien@FreeBSD.org on Sat, Apr 06, 2002 at 07:03:12PM -0800
Organization: The FreeBSD Project
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

David O'Brien <obrien@FreeBSD.org> writes:
> On Sun, Apr 07, 2002 at 12:48:29PM +1000, Bruce Evans wrote:
> > >   Log:
> > >   Add __SCCSID.  And add the NO__SCCSID, NO__RCSID, NO__RCSID_SOURCE, and
> > >   NO__COPYRIGHT knobs to more easily deal with imported vendor sources.
> > 
> > Please back this out and don't change anything to use it.  I will back
> > out the mistake that added __RCSID() similarly.  There is no end to
> > adding cruft to support unportable macros in foreign sources.  Just
> > ifdef the unportable macro invocations or remove them.  Ones with
> > vendor ids must not be removed of course.
> 
> I do not see what is so bad about these knobs.  They occur for us by the
> hundreds.  Before removing these things, how do you propose to solve the
> issue they solve?  We do not need 100 netbsd.h's, openbsd.h's, csrg.h's
> scattered around the source tree, each with a slightly different
> implementation?  Are you agreeable to /usr/include/scm.h then?

After discussing this with David, I think the best solution right now
would be to just change the macro in <sys/cdefs.h> to define __RCSID()
as nil.  This should be considered a hack to help reduce conflicts
with NetBSD/OpenBSD sources.

Best regards,
Mike Barcroft

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message