From nobody Sun Jul 13 15:40:22 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bg8m71Ch9z617Bf; Sun, 13 Jul 2025 15:40:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bg8m65XSyz42pD; Sun, 13 Jul 2025 15:40:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752421222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Z9Y78t1anJnupUmvEjx+wq6fdd8UZmCpZy/OBzkdpbQ=; b=PkfPLEWVfQCinPm2dZthNOYgEXWIw4lkCcnKrq1GKjDNU6FAvQ3TZI5guOYLXk/Nra2lov j9lFv9DjcVenOQGHUzttgNUArq7ZmLUj8U91EH0xKpnho25bKxbMGQnoH/RMC9wKdYKcn2 sLK74UJG4ucRwZ/4LD8pXwO6oR9pq0MYJcij/0WBa55I0SxCtYwKm/zN1Hf3e73vulfzbC 4fHxEKLbB8b4cMbjsr/r2o1WHotQIzA4U0OQ4pM7BAcjHmaob0E1E9yljcN4PFMSMJO8a7 uJNlyL+/git/PvC+47LZ6ul1hLG7gN3Xqyw826Vp4bt1QiAXiY55HPaB/ic5mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752421222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Z9Y78t1anJnupUmvEjx+wq6fdd8UZmCpZy/OBzkdpbQ=; b=P9KY9tzhvX6fd70T3JqH/wMltFmjdOBmqa0BQGHIqWMl69eZhm0M7EneMyhgTfLDXP1BNh lBJWdqRDmmjGA8YHNiG1IKjWB70yD3B5pTmlU73qafiyVLBes2o126AWvNjyETK+odd9xv kguQm3at5smbQGtF/IfcfQ1dl/t3Mb753ZzEt71aQiN+7QijSli6y5UQAGtodmC1C4XqX8 2aSQFPRAVIdADCMAvGWPkh5JudRJbUVVTyfi7eUZAASi1Fj4T9aMp88Mi/4Ap8Buk/e9wY m11MNW3xZEe2BHerGY9GvfKudPm6uAM4wEteNdsgkFyxyY+TOhV9dG0+a3NaGw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1752421222; a=rsa-sha256; cv=none; b=ex0QVvREBdvC7lAJ59AcJuIUa0m+IayXiFaJdfQIXd65GiYpiU+zp/zA0M3eApZdFoibGk FSCIhw/yVzZ9ThuHtt1KUSKMpXohUka5xo0lOs3OeQmrNCrPHACWzumCIVi9exoxZNo73s cwZtfJh0Ysx4zB4QZja2wfuKviLcRTe5M5+Zw/ozLmmH7l9xUV/T4ymoD/KAtZpsQjF5PY 6pObteyIDX0P8tevmhuA9KTWTGDvujpQutf43Wlv442bjF6nQJ+4f628JoAIOAbDfiHdYz 9euOIaaip2HugQB45iFT/dKiMJbadYfERMcbIyVnX1m0ZVgY0DAJQx7DgzvB5Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bg8m64gg1zRm; Sun, 13 Jul 2025 15:40:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56DFeMkj032828; Sun, 13 Jul 2025 15:40:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56DFeMNn032825; Sun, 13 Jul 2025 15:40:22 GMT (envelope-from git) Date: Sun, 13 Jul 2025 15:40:22 GMT Message-Id: <202507131540.56DFeMNn032825@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Eugene Grosbein Subject: git: 8f43b39b1c38 - stable/14 - ifconfig_netlink.c: MFC: optimise non-listing case List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: eugen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 8f43b39b1c38bde166314d4682daae7bf15a5445 Auto-Submitted: auto-generated The branch stable/14 has been updated by eugen: URL: https://cgit.FreeBSD.org/src/commit/?id=8f43b39b1c38bde166314d4682daae7bf15a5445 commit 8f43b39b1c38bde166314d4682daae7bf15a5445 Author: Alexander V. Chernikov AuthorDate: 2025-07-01 13:16:57 +0000 Commit: Eugene Grosbein CommitDate: 2025-07-13 15:38:58 +0000 ifconfig_netlink.c: MFC: optimise non-listing case This change produced by melifaro and the commit is concerted with him as he is pretty busy IRL these days. The change restores performance of /sbin/ifconfig utility for non-listing case after it switched from rtsock to netlink(4) API in FreeBSD 14+. PR: 287872 (cherry picked from commit b1b17432aa1be670564161232d110461a5dde4ce) --- sbin/ifconfig/ifconfig_netlink.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sbin/ifconfig/ifconfig_netlink.c b/sbin/ifconfig/ifconfig_netlink.c index 03fe1e418082..11b3595dafe6 100644 --- a/sbin/ifconfig/ifconfig_netlink.c +++ b/sbin/ifconfig/ifconfig_netlink.c @@ -162,7 +162,7 @@ struct ifmap { * Memory is allocated using snl temporary buffers */ static struct ifmap * -prepare_ifmap(struct snl_state *ss) +prepare_ifmap(struct snl_state *ss, const char *ifname) { struct snl_writer nw = {}; @@ -170,6 +170,8 @@ prepare_ifmap(struct snl_state *ss) struct nlmsghdr *hdr = snl_create_msg_request(&nw, RTM_GETLINK); hdr->nlmsg_flags |= NLM_F_DUMP; snl_reserve_msg_object(&nw, struct ifinfomsg); + if (ifname != NULL) + snl_add_msg_attr_string(&nw, IFLA_IFNAME, ifname); if (! (hdr = snl_finalize_msg(&nw)) || !snl_send_message(ss, hdr)) return (NULL); @@ -457,7 +459,7 @@ list_interfaces_nl(struct ifconfig_args *args) nl_init_socket(&ss); - struct ifmap *ifmap = prepare_ifmap(&ss); + struct ifmap *ifmap = prepare_ifmap(&ss, args->ifname); struct iface **sorted_ifaces = snl_allocz(&ss, ifmap->count * sizeof(void *)); for (uint32_t i = 0, num = 0; i < ifmap->size; i++) { if (ifmap->ifaces[i] != NULL) {