From owner-freebsd-bugs Sun Jul 9 20:31:26 1995 Return-Path: bugs-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id UAA24113 for bugs-outgoing; Sun, 9 Jul 1995 20:31:26 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id UAA24107 for ; Sun, 9 Jul 1995 20:31:24 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id UAA10521; Sun, 9 Jul 1995 20:31:27 -0700 From: "Rodney W. Grimes" Message-Id: <199507100331.UAA10521@gndrsh.aac.dev.com> Subject: Re: bin/606: tcpdump(1) doesn't show appletalk packets correctly To: candy@fct.kgc.co.jp Date: Sun, 9 Jul 1995 20:31:27 -0700 (PDT) Cc: freebsd-bugs@freefall.cdrom.com In-Reply-To: <199507100320.UAA23960@freefall.cdrom.com> from "Toshihiro Kanda" at Jul 9, 95 08:20:03 pm X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 1024 Sender: bugs-owner@FreeBSD.org Precedence: bulk Visial first pass review spots a new bug introduced by this patch, please verify... > > > >Number: 606 > >Category: bin > >Synopsis: tcpdump(1) doesn't show appletalk packets correctly ... > *** /usr/src/usr.sbin/tcpdump/tcpdump/print-ether.c Wed Oct 5 07:31:44 1994 > --- tcpdump/tcpdump/print-ether.c Mon Jul 10 11:02:56 1995 > *************** > *** 122,128 **** > && lp->llc_snap_oui[1] == 0x00 > && lp->llc_snap_oui[2] == 0x07) { > printf("[ethertalk] "); > ! ddp_print((struct atDDP *)((char *)lp + 6), > length - 6); > } else { > if(!eflag) { > --- 122,128 ---- > && lp->llc_snap_oui[1] == 0x00 > && lp->llc_snap_oui[2] == 0x07) { > printf("[ethertalk] "); > ! ddp_print((struct atDDP *)((char *)lp + 8), > length - 6); Should that now not also be ``length - 8'') :-) -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Reliable computers for FreeBSD