From owner-svn-src-all@FreeBSD.ORG Sat Jan 9 17:40:09 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 91F0D106568B; Sat, 9 Jan 2010 17:40:09 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.cksoft.de (mail.cksoft.de [IPv6:2001:4068:10::3]) by mx1.freebsd.org (Postfix) with ESMTP id 1F4328FC17; Sat, 9 Jan 2010 17:40:09 +0000 (UTC) Received: from localhost (amavis.fra.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 3191D41C67E; Sat, 9 Jan 2010 18:40:07 +0100 (CET) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([192.168.74.103]) by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id WaH4QUA6xe9R; Sat, 9 Jan 2010 18:40:06 +0100 (CET) Received: by mail.cksoft.de (Postfix, from userid 66) id 76FCE41C679; Sat, 9 Jan 2010 18:40:06 +0100 (CET) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 579114448EC; Sat, 9 Jan 2010 17:36:32 +0000 (UTC) Date: Sat, 9 Jan 2010 17:36:32 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: "M. Warner Losh" In-Reply-To: <20100109.100512.623571555980925615.imp@bsdimp.com> Message-ID: <20100109173314.V50938@maildrop.int.zabbadoz.net> References: <201001081901.o08J1pjc062909@svn.freebsd.org> <20100110.001429.173527971.nyan@FreeBSD.org> <20100109.100512.623571555980925615.imp@bsdimp.com> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, nyan@freebsd.org Subject: Re: svn commit: r201815 - head X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jan 2010 17:40:09 -0000 On Sat, 9 Jan 2010, M. Warner Losh wrote: > In message: <20100110.001429.173527971.nyan@FreeBSD.org> > TAKAHASHI Yoshihiro writes: > : In article <201001081901.o08J1pjc062909@svn.freebsd.org> > : "Bjoern A. Zeeb" writes: > : > : > To avoid hardcoding further kernel configuration names for > : > make universe, split the logic into two parts: > : > - 1st to build worlds and generate kernel configs like LINT. > : > - 2nd to build kernels for a given TARGET architecture correctly > : > finding all newly generated configs, not knowing anything about > : > LINT anymore. (*) > : > : > +universe_kernels: universe_kernconfs > : > +BUILD_ARCH!= uname -p > : > : Should this be "uname -m"? > : > : > : > +TARGET?= ${BUILD_ARCH} > : > +KERNCONFS!= cd ${.CURDIR}/sys/${TARGET}/conf && \ > : > + find [A-Z0-9]*[A-Z0-9] -type f -maxdepth 0 \ > : > + ! -name DEFAULTS ! -name NOTES > > Yes. Also, the name BUILD_ARCH is misleading, since it corresponds to > MACHINE, not to MACHINE_ARCH. it is clear that it is used in the > MACHINE context, not the MACHINE_ARCH context. > > These two are often confused, but many of the embedded platforms have > added to the confusion and it is unclear where the sharp dividing line > should be here anymore. It used to be separate boot environment, but > even that has gotten fuzzy for architectures like mips and arm that > boot with a huge variety of boot loaders... I guess the intial problem I had it from was introduced in r54311 to Makefile.inc1, which nowadays reads like: BUILD_ARCH!= uname -p So, the suggested correction would be: MACHINE!= uname -m I wonder if I should use XMACHINE but that usually means "cross"(building). I could use _MACHINE!= to not confuse it with MACHINE from Makefile.inc1? /bz -- Bjoern A. Zeeb It will not break if you know what you are doing.