From owner-svn-src-all@freebsd.org Fri May 24 20:29:54 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D576715B4A38; Fri, 24 May 2019 20:29:53 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-it1-x12a.google.com (mail-it1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6DB4676960; Fri, 24 May 2019 20:29:53 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-it1-x12a.google.com with SMTP id m140so15632466itg.2; Fri, 24 May 2019 13:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IdbtFmNn57k6PHikOarFxmgA6CJXY2FsQWr8DBef3Sk=; b=Dhe+C0nzsyh/MLAfzk+HdkuPvemk2fDt8HrVc0weCqPHafhXY1wniLAt2fYY6r7opL uyOvHhYqGS7LnT4uPS1keQEkQWYe/gAj6NNmHBTXMpV7d+WNgnjh740J5PWiPXifZGqL YlCS3MH14LNm6fco7Pnscvjn7b3qrQsY1aFy05BP6Wy+IhffFfbFPU8mbynezllbUBWs P56dmXnkVIUz2WAI5E2ho/xNPS2+JG7b/lb8hg0DWZnrx0gGSZ5vMbcPujGVw5UJwiZO BpeYD1PvvPw15swgpl+D4udi/dioN8PQH0Y3JLyJh/mkRNibLNIvIBZI14EqAFEYVL7/ 0I+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IdbtFmNn57k6PHikOarFxmgA6CJXY2FsQWr8DBef3Sk=; b=OBjy/s1FTX64wd6L208au+1E4Q8GpTcjLbeXt4NRbe+qqBQWZvIG8m7QlO5JG60PUj YXRqc/kzN+d+KQrf74ctm1ssR6cVtI2dVVvNw0IXjVR1ZuX2k3KtGcicNFl0qWhrHQQz w2K8Ah+0rwitLRUfw6su2vWNhCF0k774rjRn+RjZFJCViK/wZ4oa0BZy4Ba0scg8H5ul Rxtv6KMz2wd9biIDMggDcKRhyu3631/+n0BXmgD/xwvH55vLbNFlDzHcoICDhohv95Au hcH8NcoXKEuwI2Ffi9t3++dAlsyKfb6tUt8U/NcIw/l/uHkeSbQyfARTd7Z5B9MVer7z z8WA== X-Gm-Message-State: APjAAAV0faEcGagUTSCQUEprTjcgF/aoze41zCPI2wzyoWutHJtelahS 1kZ4ohewMg3p4EhJ0e0Yx864EqcItmw= X-Google-Smtp-Source: APXvYqxswZdeAHU6KzFw3GQmiehRHo7UxbSAn1TxQQ0U7obAyAlE9JU7BLeSgI/qr0IKsZATTn52pw== X-Received: by 2002:a02:b47:: with SMTP id 68mr24430096jad.66.1558729792351; Fri, 24 May 2019 13:29:52 -0700 (PDT) Received: from titan.knownspace (173-25-245-129.client.mchsi.com. [173.25.245.129]) by smtp.gmail.com with ESMTPSA id e2sm1596066ith.39.2019.05.24.13.29.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 May 2019 13:29:52 -0700 (PDT) Date: Fri, 24 May 2019 15:29:41 -0500 From: Justin Hibbits To: Alexey Dokuchaev Cc: Piotr Kubaj , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r348250 - head/sys/powerpc/conf Message-ID: <20190524152941.40f7e239@titan.knownspace> In-Reply-To: <20190524202252.GA72774@FreeBSD.org> References: <201905242001.x4OK1xA6091025@repo.freebsd.org> <20190524151651.7e6b7f09@titan.knownspace> <20190524202252.GA72774@FreeBSD.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; powerpc64-portbld-freebsd13.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6DB4676960 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.969,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 May 2019 20:29:54 -0000 On Fri, 24 May 2019 20:22:52 +0000 Alexey Dokuchaev wrote: > On Fri, May 24, 2019 at 03:16:51PM -0500, Justin Hibbits wrote: > > On Fri, 24 May 2019 20:01:59 +0000 (UTC) Piotr Kubaj wrote: > > > New Revision: 348250 > > > URL: https://svnweb.freebsd.org/changeset/base/348250 > > > > > > Log: > > > Add snd_hda(4) to GENERIC64 used by powerpc64. > > > > > > amd64 also has snd_hda(4) in GENERIC. > > > > > > Modified: > > > head/sys/powerpc/conf/GENERIC64 > > > ... > > > > To note: This was done because there's a strange bug in the snd_hda > > module, with the hdaa component. For some reason it either doesn't > > find all the internal components it needs, or something, because > > there's a NULL dereference when trying to call a kobj method in > > hdaa_attach(). > > So this commit essentially masks the real bug somewhere rather than > fixing it, is this what you're saying? > > ./danfe It's a viable workaround to a problem that reaches a wide audience. Since it works built-in, I found it acceptable. I probably should have filed a bug for it a year ago when I hit it and worked around it, but it could also very well be a compiler issue. By the way, it works fine on powerpc (32-bit) loaded as a module. - Justin