From owner-freebsd-net@freebsd.org Wed Apr 25 20:04:16 2018 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AFE50FAEC05 for ; Wed, 25 Apr 2018 20:04:16 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 40E717AAC5 for ; Wed, 25 Apr 2018 20:04:16 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id EF15AFAEC03; Wed, 25 Apr 2018 20:04:15 +0000 (UTC) Delivered-To: net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DCCF6FAEC01; Wed, 25 Apr 2018 20:04:15 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-lf0-x230.google.com (mail-lf0-x230.google.com [IPv6:2a00:1450:4010:c07::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 549D77AAA3; Wed, 25 Apr 2018 20:04:15 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-lf0-x230.google.com with SMTP id q5-v6so27248595lff.12; Wed, 25 Apr 2018 13:04:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=3sCM6E5N4KvBh7rCULFbBykZcPC8ujEmMoOZncpve1E=; b=rvNgNFRINHHCMF8YX2TNllAXuL/L1C6r1j6txuUCIA6ZNCozh+OJoxTxlcPgjKN51E r1/j0D5zRuFn/+mmR7geapji+uoglv+rcGmtZKgDRuafy1VIC4xU/zIOhCDKALBlKIiB O7bvAB+VPip9wuO8YnEM+w1KVfpRw3mnOTjYT70AKdyL1yY5Qxk7pbKwNPOJF9kRD/kp Dw4cDFP25au9cMQZHXOjDsgmn6ItYenXxNrektPnFhf0gSOYGB8oCjlWf0cYA4X1t65i IwW9eKi7j/r8UInANnwXc0s671pjrjxRpHDugqr25of9cvMfv6h4by52HlGLKZr7yxPX M5Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3sCM6E5N4KvBh7rCULFbBykZcPC8ujEmMoOZncpve1E=; b=Ei5Pfc1zEtZJxLb0+w3e0VDL3+xENDirtz/D6nek+evGRkCB1oigbl1SRZg3vMPSAq w7gmqcXzRxgCrgd1Y9GJfRtbUL47iv1GH5fw1/s+932d96KKuOri1zCo08fCoW6dXpIT 0a2jCWajSc2hUo0prTCPMrfNQexr3sZaPmCc5bbk35KXekf/nNBwmeFfnkhA2RTCZ+dg 2putlkz3H/WPTRbbwbKs5am4I1LiTt9rvZ4YxoQ13sQPGWnEhgmnK/HfyKoWjKTQcHc8 gSHlMBndAdoRraJKlXjh0PKc6cHvrTAFW1o5pFX/jtSiMvORXtQrCfiV2SC++TXgxTAO QJSw== X-Gm-Message-State: ALQs6tCiqikWIl63lII6qPihFJkfjvg9ouheQYjgkqlvPk1RVAUZ8FfA Zh7RM5+tvitXFvZ0vnDJKfWL4QaT/DOflTyafiqgQw== X-Google-Smtp-Source: AIpwx49b9udlSrZuQjIneuDnTsSUZMEzf05LCvbETc1cvEISt2IYhTS+VEJoPVnXsauvuVZ9rSo/p8uJRuT/Hfczwi4= X-Received: by 10.46.150.85 with SMTP id z21mr14873442ljh.127.1524686653917; Wed, 25 Apr 2018 13:04:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.46.135.75 with HTTP; Wed, 25 Apr 2018 13:04:13 -0700 (PDT) In-Reply-To: <20180424085553.GA6887@kib.kiev.ua> References: <20180424085553.GA6887@kib.kiev.ua> From: Ryan Stone Date: Wed, 25 Apr 2018 16:04:13 -0400 Message-ID: Subject: Re: mlx5(4) jumbo receive To: Konstantin Belousov Cc: FreeBSD Current , menny@mellanox.com, FreeBSD Net Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 20:04:16 -0000 On Tue, Apr 24, 2018 at 4:55 AM, Konstantin Belousov wrote: > +#ifndef MLX5E_MAX_RX_BYTES > +#define MLX5E_MAX_RX_BYTES MCLBYTES > +#endif Why do you use a 2KB buffer rather than a PAGE_SIZE'd buffer? MJUMPAGESIZE should offer significantly better performance for jumbo frames without increasing the risk of memory fragmentation.