From owner-freebsd-net@FreeBSD.ORG  Sun Apr 11 08:13:04 2004
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id BF7C216A4CE; Sun, 11 Apr 2004 08:13:04 -0700 (PDT)
Received: from out007.verizon.net (out007pub.verizon.net [206.46.170.107])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 567E743D2F; Sun, 11 Apr 2004 08:13:04 -0700 (PDT)
	(envelope-from cswiger@mac.com)
Received: from mac.com ([68.160.247.127]) by out007.verizon.net
          (InterMail vM.5.01.06.06 201-253-122-130-106-20030910) with ESMTP
          id <20040411151303.QXZZ28276.out007.verizon.net@mac.com>;
          Sun, 11 Apr 2004 10:13:03 -0500
Message-ID: <40796061.1020200@mac.com>
Date: Sun, 11 Apr 2004 11:12:33 -0400
From: Chuck Swiger <cswiger@mac.com>
Organization: The Courts of Chaos
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.7b) Gecko/20040316
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Ruslan Ermilov <ru@FreeBSD.org>
References: <20040410222112.GA23046@ip.net.ua>
In-Reply-To: <20040410222112.GA23046@ip.net.ua>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Authentication-Info: Submitted using SMTP AUTH at out007.verizon.net from
	[68.160.247.127] at Sun, 11 Apr 2004 10:13:03 -0500
cc: net@FreeBSD.org
Subject: Re: Per-interface polling(4) status
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Apr 2004 15:13:04 -0000

Ruslan Ermilov wrote:
[ ... ]
> Points I'm not sure about, and would like to hear the comments on:
> 
> - Should the initial polling status be on or off, on interfaces
>   that support it?  The current version of the patch makes it
>   off by default.

Given that polling will only take place if kern.polling.enable is set, 
IFF_POLLING can be enabled by default safely and changing the global sysctl 
will enable or disable all polling-capable interfaces, which retains the 
current behavior.

> - Should I add the code to ether_poll_register() to sanity check
>   that the interface doesn't attempt to register itself more
>   than once?

Sure.  I don't see how having an interface registered multiple times will do 
any good....?

-- 
-Chuck