From owner-dev-commits-ports-all@freebsd.org  Thu Apr 22 10:10:39 2021
Return-Path: <owner-dev-commits-ports-all@freebsd.org>
Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 892C35E8ED7;
 Thu, 22 Apr 2021 10:10:39 +0000 (UTC)
 (envelope-from grembo@freebsd.org)
Received: from mail.evolve.de (mail.evolve.de [213.239.217.29])
 (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "mail.evolve.de", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4FQtTp3VWYz3Qch;
 Thu, 22 Apr 2021 10:10:38 +0000 (UTC)
 (envelope-from grembo@freebsd.org)
Received: by mail.evolve.de (OpenSMTPD) with ESMTP id d6efc2ee;
 Thu, 22 Apr 2021 10:10:29 +0000 (UTC)
Received: by mail.evolve.de (OpenSMTPD) with ESMTPSA id 29d6d493
 (TLSv1.3:AEAD-CHACHA20-POLY1305-SHA256:256:NO); 
 Thu, 22 Apr 2021 10:10:27 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (1.0)
Subject: Re: git: 5b7c17856512 - main - git hooks: Rework authorship
 instructions.
From: Michael Gmelin <grembo@freebsd.org>
In-Reply-To: <YIFK/tIpcfqWTWVh@FreeBSD.org>
Date: Thu, 22 Apr 2021 12:10:26 +0200
Cc: Mathieu Arnold <mat@freebsd.org>, ports-committers@freebsd.org,
 dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Message-Id: <FB32E75F-9AF0-41C2-9EE1-B10D931DECD0@freebsd.org>
References: <YIFK/tIpcfqWTWVh@FreeBSD.org>
To: Alexey Dokuchaev <danfe@freebsd.org>
X-Mailer: iPhone Mail (18D70)
X-Rspamd-Queue-Id: 4FQtTp3VWYz3Qch
X-Spamd-Bar: /
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [0.00 / 15.00];
 ASN(0.00)[asn:24940, ipnet:213.239.192.0/18, country:DE];
 local_wl_from(0.00)[freebsd.org]
X-BeenThere: dev-commits-ports-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for all branches of the ports repository
 <dev-commits-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-ports-all>, 
 <mailto:dev-commits-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-ports-all/>
List-Post: <mailto:dev-commits-ports-all@freebsd.org>
List-Help: <mailto:dev-commits-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-ports-all>, 
 <mailto:dev-commits-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2021 10:10:39 -0000



> On 22. Apr 2021, at 12:08, Alexey Dokuchaev <danfe@freebsd.org> wrote:
>=20
> =EF=BB=BFOn Thu, Apr 22, 2021 at 09:52:19AM +0000, Mathieu Arnold wrote:
>> ...
>> diff --git a/.hooks/prepare-commit-msg b/.hooks/prepare-commit-msg
>> @@ -44,6 +44,9 @@ $(awk '1;/^#$/{exit}' "$1")
>> # <then a blank line>
>> #                                                         72 columns --|
>> #
>> +# Do not add a Submitted by line.  If someone besides the committer sent=
 in the
>> +# change, the commit author should be set using \`git commit --author\`.=

>> +#
>=20
> This doesn't seem right.  "Submitted by" can be a list, not a single name.=

> Also, I rarely commit submitted work verbatim, so technically the author
> is me 99% of the time, yet it would be appropriate to give attribution to
> the original submitter, esp. if there is no PR number (private submission)=
.
>=20

I agree that author should only be used if a submission is applied unaltered=
 (pull request/git patch).

-m


> ./danfe