From owner-svn-src-head@freebsd.org Mon Jul 18 15:44:27 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9CFA1B9D19C for ; Mon, 18 Jul 2016 15:44:27 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-it0-x22b.google.com (mail-it0-x22b.google.com [IPv6:2607:f8b0:4001:c0b::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 672231673 for ; Mon, 18 Jul 2016 15:44:27 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-it0-x22b.google.com with SMTP id f6so77471116ith.0 for ; Mon, 18 Jul 2016 08:44:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=cl07vYfD4s86oHc4oH/LPcCQpKewvEwKAX06POndnUc=; b=OftsgzVbWwdiKWrwJRETtDLNI3RXBFnb0kehISAu50G/nOuUVwCuxYr2rZfAKYo98O UUZjpV92U7V2QpQck6fiUWwtBg00ZMt/ARHFXOQTKeICAZ8lMHSsGj+2nPeKSdv1Uxqc mVz3MOMVIdxsBdrHvbsysGpCaYa9ur2d5J2Sc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=cl07vYfD4s86oHc4oH/LPcCQpKewvEwKAX06POndnUc=; b=Xew5j11+96aQpsm6BCq916zZXYzebxOSwHbaYwi9jaqh6jU9WvWk+MtXsjUDSdzTVl 3eolf/MAVQ2Vbh+DrCOvIpIepnl2rxABzvmz8TgOUWb2f7ZYTCz2zg+zzlf2qguWb1Vd QR8jaytSrjtEeaJZW9ErBsS3aTdoquK7a9WfM9nzg1WuEJ83mQl3H95gihIgFXGIKDiS zpv6dbmZAOrQU16aW9gtgcJpl7twlR1sffwhUAEfpkhJzns0/Z6jXcvFZqGjEGEwmqQ5 rdsUIw3B++2dU8DqpMeZC5bkE9Yl3EaztZDNJiP5XTZiu1cmZ9spAj1T0X4TsHTxChMY A/PQ== X-Gm-Message-State: ALyK8tKojdv2/dIFCMijYLvJRALuUNBnG+ozx8bL/Pa6zMWXRyVb4aWinYXxDZhd8VW4gh7U X-Received: by 10.36.34.14 with SMTP id o14mr36173789ito.11.1468856666594; Mon, 18 Jul 2016 08:44:26 -0700 (PDT) Received: from [100.127.65.10] ([69.53.245.200]) by smtp.gmail.com with ESMTPSA id v11sm9023876iod.43.2016.07.18.08.44.24 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 18 Jul 2016 08:44:25 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r302998 - head/sys/kern From: Randall Stewart In-Reply-To: <201607180929.u6I9T9Uw063705@repo.freebsd.org> Date: Mon, 18 Jul 2016 17:44:20 +0200 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <64C1543A-3EDE-4852-88EA-5B0B78FCF016@netflix.com> References: <201607180929.u6I9T9Uw063705@repo.freebsd.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2016 15:44:27 -0000 Gleb: This now leaks TCP-PCB=E2=80=99s since you have broken the return codes = with all your fixes that used to be in here. It was return 1 =E2=80=94 You stopped the callout return 0 =E2=80=94 The callout could not be stopped return -1 =E2=80=94 The callout was not running. The LLRef code that was crashing in in.c depended on this to know to = free the memory.. i.e. if was > 0 then they needed to free the memory. TCP depends on a return 0 to indicate the async-drain function will be = called back and thus increments a refcnt and waits for the callback. You now return 0 when no timer was active.. which makes the stack then = wait for the not forth coming async-drain call. R > On Jul 18, 2016, at 11:29 AM, Gleb Smirnoff = wrote: >=20 > Author: glebius > Date: Mon Jul 18 09:29:08 2016 > New Revision: 302998 > URL: https://svnweb.freebsd.org/changeset/base/302998 >=20 > Log: > Revert the last commit. It must get more review and testing first. >=20 > Modified: > head/sys/kern/kern_timeout.c >=20 > Modified: head/sys/kern/kern_timeout.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/kern/kern_timeout.c Mon Jul 18 09:26:06 2016 = (r302997) > +++ head/sys/kern/kern_timeout.c Mon Jul 18 09:29:08 2016 = (r302998) > @@ -1381,7 +1381,7 @@ again: > CTR3(KTR_CALLOUT, "failed to stop %p func %p arg %p", > c, c->c_func, c->c_arg); > CC_UNLOCK(cc); > - return (-1); > + return (0); > } >=20 > c->c_iflags &=3D ~CALLOUT_PENDING; >=20 -------- Randall Stewart rrs@netflix.com 803-317-4952