From owner-cvs-src@FreeBSD.ORG Mon Mar 31 16:37:16 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1BCE137B404 for ; Mon, 31 Mar 2003 16:37:16 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 981DF43FBF for ; Mon, 31 Mar 2003 16:37:14 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 8188 invoked by uid 1000); 1 Apr 2003 00:37:15 -0000 Date: Mon, 31 Mar 2003 16:37:15 -0800 (PST) From: Nate Lawson To: John Baldwin In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: RE: cvs commit: src/sys/pci if_dc.c if_pcn.c if_rl.c if_sf.cif_sis.c if_ste.c if_tl.c if_vr.c if_wb.c if_xl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Apr 2003 00:37:16 -0000 On Mon, 31 Mar 2003, John Baldwin wrote: > On 31-Mar-2003 John Baldwin wrote: > > jhb 2003/03/31 12:22:00 PST > > > > FreeBSD src repository > > > > Modified files: > > sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c > > if_ste.c if_tl.c if_vr.c if_wb.c if_xl.c > > Log: > > Add missing ()'s so that these drivers all compile again. > > > > Noticed by: jake > > Tested on: i386 (compile) > > Also, the pcn(4) driver still has some possibly bogus locking in > its probe routine. Not sure if other drivers have locks in their > probe routines. Thank you jhb and jake for fixing the KASSERT ()'s. I had options INVARIANTS in my kernel so I'm not sure why this was not caught. I was compiling them as modules so does INVARIANTS not enable KASSERT in modules? I'll do a quick grep for other bogus locking shortly. -Nate