From owner-svn-ports-head@freebsd.org Thu Oct 18 20:12:24 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9D016F73A52; Thu, 18 Oct 2018 20:12:24 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 45A897CAE0; Thu, 18 Oct 2018 20:12:24 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id E05CB22BCC; Thu, 18 Oct 2018 16:12:17 -0400 (EDT) Received: from web6 ([10.202.2.216]) by compute4.internal (MEProxy); Thu, 18 Oct 2018 16:12:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=DK+/GUlXQMAncB9j7uCP/cLglgqlWHUqzGgrzm1JI rI=; b=O22d/l6maY8+dU/QMlYUzDsrxGavS/3v+gZpYhkQWI7Z/q0jn5l2+VxkN Hq1f+qjFrwnrzegBgFbXeu/dKooQLgrZBIUYi7KoToPspaD2mC9aatpp3gb9KYt5 8Ul5hQ4grwk6tskbN6eqqnJP/4jc+WTunqblXmJ41q6jc1LI3WznYsgdHrjV/zJo k4HqelPNX2KQGbX1Wg0wvJ6RLR6Gvml4OOLiGjRR1ZL2cjJN0xg4lBgA3MePdCjC h1WPHRQkJlPZE1Cjni71aibB0MZCbrS/81qnPFQZ0iqE6MOYx+W6uhdp8kERfOKh YuG/deFh58Bos2OkN6sCaKyFwIOtw== X-ME-Sender: X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 99) id 6FEF6415B; Thu, 18 Oct 2018 16:12:17 -0400 (EDT) Message-Id: <1539893537.3422544.1546940568.7751C422@webmail.messagingengine.com> From: Tobias Kortkamp To: Steve Wills , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-cc4e8f33 Date: Thu, 18 Oct 2018 22:12:17 +0200 In-Reply-To: <201810181955.w9IJtde2086453@repo.freebsd.org> Subject: Re: svn commit: r482373 - head/multimedia/tautulli References: <201810181955.w9IJtde2086453@repo.freebsd.org> X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2018 20:12:24 -0000 On Thu, Oct 18, 2018, at 21:55, Steve Wills wrote: > Author: swills > Date: Thu Oct 18 19:55:39 2018 > New Revision: 482373 > URL: https://svnweb.freebsd.org/changeset/ports/482373 > > Log: > multimedia/tautulli: Update to 2.1.22 > > PR: 232364 > Submitted by: Nathan > > Modified: > head/multimedia/tautulli/Makefile (contents, props changed) > head/multimedia/tautulli/distinfo (contents, props changed) > > Modified: head/multimedia/tautulli/Makefile > ============================================================================== > --- head/multimedia/tautulli/Makefile Thu Oct 18 19:55:37 2018 (r482372) > +++ head/multimedia/tautulli/Makefile Thu Oct 18 19:55:39 2018 (r482373) > @@ -2,9 +2,8 @@ > # $FreeBSD$ > > PORTNAME= tautulli > -PORTVERSION= 2.0.28 > +PORTVERSION= 2.1.22 > DISTVERSIONPREFIX=v > -PORTREVISION= 0 > CATEGORIES= multimedia python > > MAINTAINER= ports@FreeBSD.org > @@ -17,22 +16,23 @@ RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}sqlite3>0:database > ${PYTHON_PKGNAMEPREFIX}openssl>0:security/py-openssl@${PY_FLAVOR} \ > ${LOCALBASE}/share/certs/ca-root-nss.crt:security/ca_root_nss > > -SUB_LIST= PYTHON_CMD=${PYTHON_CMD} > - > USES= python:2.7 shebangfix > -SHEBANG_FILES= Tautulli.py > -python_OLD_CMD= /bin/sh > - Tautulli.py is a Python script but has a wrong shebang (#!/bin/sh) so this needs to stay, or it will not be corrected and it cannot possibly be run from the rc script as is. https://github.com/Tautulli/Tautulli/blob/v2.1.22/Tautulli.py#L1 > USE_GITHUB= yes > +USE_RC_SUBR= ${PORTNAME} > + > +SHEBANG_FILES= Tautulli.py > +SUB_LIST= PYTHON_CMD=${PYTHON_CMD} > GH_ACCOUNT= Tautulli > GH_PROJECT= Tautulli > + > NO_BUILD= yes > NO_ARCH= yes > +DOCS= API.md CHANGELOG.md README.md (Aside: Is it really necessary to invent new variables with no semantic meaning that are only used in one place? This could be put directly into do-install-DOCS-on instead.) > > -USE_RC_SUBR= ${PORTNAME} > +USERS= tautulli > +GROUPS= tautulli > > -USERS= tautulli > -GROUPS= tautulli > +OPTIONS_DEFINE= DOCS > > post-patch: > ${FIND} ${WRKSRC} -name '*.orig' -delete > @@ -40,14 +40,16 @@ post-patch: > do-install: > ${MKDIR} ${STAGEDIR}${WWWDIR}/data ${STAGEDIR}${WWWDIR}/lib \ > ${STAGEDIR}${WWWDIR}/plexpy > - cd ${WRKSRC} && ${COPYTREE_SHARE} data ${STAGEDIR}${WWWDIR} > - cd ${WRKSRC} && ${COPYTREE_SHARE} lib ${STAGEDIR}${WWWDIR} > - cd ${WRKSRC} && ${COPYTREE_SHARE} plexpy ${STAGEDIR}${WWWDIR} > + (cd ${WRKSRC} ; ${COPYTREE_SHARE} data lib plexpy ${STAGEDIR}${WWWDIR}) This copies things to the wrong place due to the way COPYTREE_SHARE works (i.e. it copies data/ and plexpy/ to lib/, nothing to the stage directory). Looks like cd ${WRKSRC} && ${COPYTREE_SHARE} "data lib plexpy" ${STAGEDIR}${WWWDIR} was meant here.