From owner-cvs-all@FreeBSD.ORG Tue Apr 27 07:57:40 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 55EBF16A4CE; Tue, 27 Apr 2004 07:57:40 -0700 (PDT) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id A534343D2D; Tue, 27 Apr 2004 07:57:39 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.10/8.12.9) with ESMTP id i3REvZgr047646; Tue, 27 Apr 2004 08:57:35 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Tue, 27 Apr 2004 08:57:53 -0600 (MDT) Message-Id: <20040427.085753.34602518.imp@bsdimp.com> To: jhb@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <200404270912.48113.jhb@FreeBSD.org> References: <200404260211.i3Q2Bcrt037219@repoman.freebsd.org> <200404270912.48113.jhb@FreeBSD.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_pci.c src/sys/dev/pci pci.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Apr 2004 14:57:40 -0000 In message: <200404270912.48113.jhb@FreeBSD.org> John Baldwin writes: : On Sunday 25 April 2004 10:11 pm, Warner Losh wrote: : > imp 2004/04/25 19:11:38 PDT : > : > FreeBSD src repository : > : > Modified files: : > sys/dev/acpica acpi_pci.c : > sys/dev/pci pci.c : > Log: : > Fix two typos from PR: 65694 : > : > 1) In pci.c, we need to check the child device's state, not the parent : > device's state. : > 2) In acpi_pci.c, we have to run the power state change after the acpi : > method when the old_state is > new state, not the other way around. : : Umm, the ACPI method may turn the power to the device off (i.e., turn off the : power resource that provides power to the device), meaning that you can't : access it's PCI config registers anymore. It's quite intentional to turn the : device off using PCI first and ACPI second and then to turn the device on via : ACPI first and then PCI second. : : Unfortunately, the PR number is wrong (that's some ports PR) and there are no : PR's in the database with an originator that contains 'Remesov' or the text : 'acpi_pci' in the text fields at least none that query-pr-summary.cgi can : find. Ugh, actually, query-pr is just hosed as it thinks we have no open : PRs. *sigh* You misunderstand. When turning the device OFF, we run the acpi last. When turning the device ON, we run it first. The code ran it twice in one case and never in the other. Warner