Date: Sat, 24 Mar 2001 01:26:55 -0800 From: Julian Elischer <julian@elischer.org> To: Bruce Evans <bde@zeta.org.au> Cc: John Baldwin <jhb@FreeBSD.ORG>, Archie Cobbs <archie@dellroad.org>, arch@FreeBSD.ORG Subject: Re: Critical Regions Round II Message-ID: <3ABC685F.93B11487@elischer.org> References: <Pine.BSF.4.21.0103241928310.26714-100000@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans wrote: > > On Fri, 23 Mar 2001, Julian Elischer wrote: > > > John Baldwin wrote: > > > Archie said: > > > > Shouldn't these be, e.g., > > > > > > > > i386_disable_intr(), i386_enable_intr() > > > > > > > > and > > > > > > > > ia64_enable_intr(), ia64_disable_intr() > > > No, this code should not be used outside of sys/${MACHINE_ARCH}, which is > > > mostly how things were (aside from broken things like the joy driver) before > > > SMPng. > > > > I think the names should include either md_ or I386_ as a leadin so that people > > who are 'copying' to make their own drivers a made fully aware > > of what is going on. > > The MD names should simply be accessible in MI code. There are ^in > currently too many of them in <machine/*.h>. A few broken drivers > access MD interfaces directly: grepping for 'include.*i386/' gives: > > dev/ar/if_ar_isa.c:#include <i386/isa/ic/hd64570.h> chip definitions should become machine independent. -- __--_|\ Julian Elischer / \ julian@elischer.org ( OZ ) World tour 2000-2001 ---> X_.---._/ v To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3ABC685F.93B11487>