From owner-freebsd-current@freebsd.org Sat Jan 26 23:11:55 2019 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EBA9814B2079; Sat, 26 Jan 2019 23:11:54 +0000 (UTC) (envelope-from list_freebsd@bluerosetech.com) Received: from echo.brtsvcs.net (echo.brtsvcs.net [IPv6:2607:f740:c::4ae]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CA28971B10; Sat, 26 Jan 2019 23:11:53 +0000 (UTC) (envelope-from list_freebsd@bluerosetech.com) Received: from chombo.houseloki.net (catnip [73.240.250.185]) by echo.brtsvcs.net (Postfix) with ESMTPS id C397E38D43; Sat, 26 Jan 2019 15:11:51 -0800 (PST) Received: from [10.26.25.66] (leon.pilgrimaccounting.com [10.26.25.66]) by chombo.houseloki.net (Postfix) with ESMTPSA id 048D0293; Sat, 26 Jan 2019 15:11:51 -0800 (PST) Subject: Re: usb/234503 already committed, but needs modification to cover more devices To: Hans Petter Selasky , freebsd-current@freebsd.org, freebsd-usb@freebsd.org References: <3f9936d7-14ba-c820-3fe5-f767d968e52f@bluerosetech.com> <6c72d9bf-84ab-a9e7-598d-48f6301fa291@selasky.org> From: Mel Pilgrim Message-ID: <206f6f49-9a00-b100-d503-cfff6092ffdb@bluerosetech.com> Date: Sat, 26 Jan 2019 15:11:52 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <6c72d9bf-84ab-a9e7-598d-48f6301fa291@selasky.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CA28971B10 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of list_freebsd@bluerosetech.com designates 2607:f740:c::4ae as permitted sender) smtp.mailfrom=list_freebsd@bluerosetech.com X-Spamd-Result: default: False [-4.98 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[bluerosetech.com]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: echo.brtsvcs.net]; NEURAL_HAM_SHORT(-0.97)[-0.966,0]; IP_SCORE(-1.70)[ipnet: 2607:f740:c::/48(-4.52), asn: 36236(-3.91), country: US(-0.08)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:36236, ipnet:2607:f740:c::/48, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[185.250.240.73.zen.spamhaus.org : 127.0.0.10] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jan 2019 23:11:55 -0000 On 01/26/2019 01:24, Hans Petter Selasky wrote: > On 1/26/19 1:41 AM, Mel Pilgrim wrote: >> A quirk for a USB flashdrive was added to head (r342657), but the >> modification was too narrow. The quirk affects all of the devices >> in the Chipfancier SLC family, not just the one specific device for >> which the quirk was added. >> >> I replied to usb/234503 about this, but as this is already in head, >> I'd like someone to act on it and modify the quirk to cover all of >> the devices in the family before 12.0-R comes out (and hopefully >> MFC to stable before 11.3 comes out). >> >> As I wrote in the PR, I'm already running the patch in releng/11.2 >> in production. > > It is not a problem to make a patch to ignore the idProduct field > when matching. Will you make a patch for usb_quirk.c ? I can do up a patch, yes. The subject file thus far is scsi_da.c, not usb_quirk.c? I'm not sure how to make a quirk that is idProduct agnostic. Is there documentation on this, or can you point me an example of such an entry?