From owner-svn-src-all@freebsd.org Thu Aug 8 21:30:12 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 34A44B38AF for ; Thu, 8 Aug 2019 21:30:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 464M3R3XKcz4tbG for ; Thu, 8 Aug 2019 21:30:11 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x734.google.com with SMTP id d15so70046820qkl.4 for ; Thu, 08 Aug 2019 14:30:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d4gx8YmMMGr6DsOP0/f2GIlqcpTANeVnebBk4mVjNcQ=; b=T8Sc4H2NglztldqrV/55no9vtpz08OBrwUBmXugAdM03rBcFaC75AZctnDD3VZpsZF c6gNVoesjCx/DWyPNtqsnui28PJqqsX7t6vuy9XmkPR0ure5rmCFUbhVH/do3ni752Qt Y+TL3UHsaJ8SqlSKS4hFCGWI9vK4SoVL8fFCG+Tn52oNws480sejZ8WYbPAzwR/3LFtw 08Im+R/vA8W0jH92qnArGjx1eQg9yfuTWkiZGCSFW9E00OvkT5bTALHwyAqdK3XJOUga 6JvEfog21APLCcN0NneNXp/vT+8ZA3vbviZwbrBVN6e4m6hUTKtB65mfJvLL8qviMJBb 0Cng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d4gx8YmMMGr6DsOP0/f2GIlqcpTANeVnebBk4mVjNcQ=; b=Rn+enjGe9c7G82XZNkLwSwqz26JDP4uZ9X9G6VamQvlutcBr338wlgQTl8jfKniADr MpEvSkyue84iae4asaEzdy2K204Sj0Dwb/DQzlZ8mzN8vpX+7DCULg4t/f9YEli9ff7n NB4bKj6wpquGQj2zowrN1VWnv8NzQxdK6RK4F5FRgcn1zMZeC8aHvr1/aNungwI6e2Qb vnsoOzaL2zyMnmSnSO837HtuBG0ZlP59bMWUkcHLf2pxmutgW8rSee9QWzsiVd0ho1GD zl2aD1AxpF5RP1QnAO5R5NVFZBAahWy188MLqnCII2CCbHykOt3jaGzROifTbBSAWf16 hX8w== X-Gm-Message-State: APjAAAWdy953zfmsi5UZ97fcbF5oIX57afTdbmmIMFaMhb3THccaPz01 29gTobUOfRoOtq0hBZ0+6AfT3A9YPIwRxpo7McNHlQ== X-Google-Smtp-Source: APXvYqyfkB9UfT38rCojBLofn3ZrXqKHcHtD3qQXAT0Ric9Ntm6JwxOiJ4J5R2u3t+0OJQKsnrHByDNWMcnBJ3HmcxA= X-Received: by 2002:a37:9307:: with SMTP id v7mr8455100qkd.495.1565299810059; Thu, 08 Aug 2019 14:30:10 -0700 (PDT) MIME-Version: 1.0 References: <201908082009.x78K9bCV069231@repo.freebsd.org> In-Reply-To: From: Warner Losh Date: Thu, 8 Aug 2019 15:29:59 -0600 Message-ID: Subject: Re: svn commit: r350778 - head/sys/contrib/zstd/lib/common To: "Conrad E. Meyer" Cc: Warner Losh , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 464M3R3XKcz4tbG X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=T8Sc4H2N; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::734) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-5.99 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-1.00)[-0.998,0]; RCVD_IN_DNSWL_NONE(0.00)[4.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.99)[ip: (-9.45), ipnet: 2607:f8b0::/32(-3.03), asn: 15169(-2.43), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Aug 2019 21:30:12 -0000 Thanks Conrad for upstreaming... Warner On Thu, Aug 8, 2019 at 3:29 PM Conrad Meyer wrote: > Thanks Warner for noticing and fixing this. > > I've sent the patch upstream to hopefully be addressed there as well: > > https://github.com/facebook/zstd/pull/1713 > > Best, > Conrad > > On Thu, Aug 8, 2019 at 1:09 PM Warner Losh wrote: > > > > Author: imp > > Date: Thu Aug 8 20:09:36 2019 > > New Revision: 350778 > > URL: https://svnweb.freebsd.org/changeset/base/350778 > > > > Log: > > Stopgap fix for gcc platforms. > > > > Our in-tree gcc doesn't have a no-tree-vectorize optimization knob, so > we get a > > warning that it's unused. This causes the build to fail on all our gcc > platforms. > > Add a quick version check as a stop-gap measure to get CI building > again. > > > > Modified: > > head/sys/contrib/zstd/lib/common/compiler.h > > > > Modified: head/sys/contrib/zstd/lib/common/compiler.h > > > ============================================================================== > > --- head/sys/contrib/zstd/lib/common/compiler.h Thu Aug 8 20:07:38 > 2019 (r350777) > > +++ head/sys/contrib/zstd/lib/common/compiler.h Thu Aug 8 20:09:36 > 2019 (r350778) > > @@ -128,7 +128,7 @@ > > } > > > > /* vectorization */ > > -#if !defined(__clang__) && defined(__GNUC__) > > +#if !defined(__clang__) && defined(__GNUC__) && __GNUC__ > 5 > > # define DONT_VECTORIZE __attribute__((optimize("no-tree-vectorize"))) > > #else > > # define DONT_VECTORIZE > > >