From owner-svn-src-all@freebsd.org Fri Jun 19 11:07:20 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 39432347BB4; Fri, 19 Jun 2020 11:07:20 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49pGGv5qxJz3fLw; Fri, 19 Jun 2020 11:07:19 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qk1-x732.google.com with SMTP id q8so8446415qkm.12; Fri, 19 Jun 2020 04:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=t03EiiqPN/4OqaH8CxIqUMNW6QXQKJaGF3kCLQiQdTA=; b=uj84xCgXzLiYzBrrYzDWhLJwuUYiJN5xe2CR4FcIQGASdpLXmxbIm8dOyQnOjVeJoh Bknhe+rIV/tpbQB8VxV6RiYw40iHHovApiAGi5y2BoRXX6MxhEpBbcr04nFDWSZlOZDj U5GgIuT3r7pJ72C82tLm/i9t5LREM5f8KsH4YdqLhwSaC6ErUxRtgtsOJhLWhiERKPCj /tvOUid54ZDIXY2uV0vWlczFClvhTPOwXBAU30d2BCAipYazNMhjiyBMY/wCF4c8guW6 2eP1qYTCw231Rdva2Dc2vO2UaTnoEvp502jUv81oCZ1kE9W/ao0v+1qiJoe/rgFRURI4 qQ3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=t03EiiqPN/4OqaH8CxIqUMNW6QXQKJaGF3kCLQiQdTA=; b=WLFzA1Kx2ktZy2cKZmEMrQ++BFwSwyLUAO2+vUMnst29x9vuJNZ1VPNx5k+r9hisUk TqAnqs/SSU8iqVaWxo+XqXZj5apb/9LeDwqQ7Oc9soNaElRLfj38LqAAS+X+49YH//Z4 Y8wDawoz1TR8fHfiprEYfMt35uPKFnJSXMvZ8b2kZ9nJxOk0JDspWuJhDcvcL/SrCBZU 6475rxWe8Y2Cm93pQzS4t94248RYiLvWp11CePCZEcTLrq+AE0hMYIVEzn4bLYwg1B/Y 0dNrWTMlzZiWRn+HtrIiDCxtgoHgY+jpp6NdzsNV1rxE+wKITP1+Ia/Fc/wO/v/ex723 QdIQ== X-Gm-Message-State: AOAM530RzYXmWxJb0tZ/yrUU4rAjxDexLG3AAR6YJzZvpiDtbQeNzt8S w1XKnMqiUbjPBfoQ/Q4ty7BIdFfhIBM= X-Google-Smtp-Source: ABdhPJx+ne2Q6VjCouuVqRY6Pl9aB9DQeOtGQy339C/xZUJeEQJxAPgzFG3WpqBR++Rfm3J9oqS8SQ== X-Received: by 2002:a05:620a:2050:: with SMTP id d16mr2999573qka.215.1592564838514; Fri, 19 Jun 2020 04:07:18 -0700 (PDT) Received: from raichu (bras-base-toroon0560w-grc-20-184-147-206-12.dsl.bell.ca. [184.147.206.12]) by smtp.gmail.com with ESMTPSA id k17sm6575133qtb.5.2020.06.19.04.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2020 04:07:17 -0700 (PDT) Sender: Mark Johnston Date: Fri, 19 Jun 2020 07:07:15 -0400 From: Mark Johnston To: Li-Wen Hsu Cc: src-committers , svn-src-all , svn-src-head Subject: Re: svn commit: r362361 - in head/sys: compat/linuxkpi/common/src vm Message-ID: <20200619110715.GD97300@raichu> References: <202006190332.05J3W53u006443@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 49pGGv5qxJz3fLw X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2020 11:07:20 -0000 On Fri, Jun 19, 2020 at 06:02:18PM +0800, Li-Wen Hsu wrote: > On Fri, Jun 19, 2020 at 11:32 AM Mark Johnston wrote: > > > > Author: markj > > Date: Fri Jun 19 03:32:04 2020 > > New Revision: 362361 > > URL: https://svnweb.freebsd.org/changeset/base/362361 > > > > Log: > > Add a helper function for validating VA ranges. > > > > Functions which take untrusted user ranges must validate against the > > bounds of the map, and also check for wraparound. Instead of having the > > same logic duplicated in a number of places, add a function to check. > > > > Reviewed by: dougm, kib > > Sponsored by: The FreeBSD Foundation > > MFC after: 1 week > > Differential Revision: https://reviews.freebsd.org/D25328 > > I'm not sure if it's this one, or 3623630, the following i386 tests > all panicked: It was 3623630, which was totally wrong. > https://ci.freebsd.org/job/FreeBSD-head-i386-test/9681/console > > 00:11:31.669 lib/libc/net/protoent_test:protoent -> panic: > __rw_wlock_hard: recursing but non-recursive rw vm object @ > /usr/src/sys/vm/vm_object.c:869 > > https://ci.freebsd.org/job/FreeBSD-head-i386-test/9682/console > (includes the fix or r362363) > > 00:27:53.864 bin/pkill/pkill-j_test:main -> Sleeping thread (tid > 100115, pid 65628) owns a non-sleepable lock > > https://ci.freebsd.org/job/FreeBSD-head-i386-test/9683/console > > 00:02:26.917 bin/pkill/pkill-j_test:main -> Sleeping thread (tid > 100152, pid 26582) owns a non-sleepable lock > > Can you help check these? I reverted the change. Sorry for the breakage.