From owner-freebsd-ports@FreeBSD.ORG Mon May 25 18:01:04 2009 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 02C2B106567B; Mon, 25 May 2009 18:01:04 +0000 (UTC) (envelope-from itetcu@FreeBSD.org) Received: from it.buh.tecnik93.com (it.buh.tecnik93.com [81.196.204.98]) by mx1.freebsd.org (Postfix) with ESMTP id AC3808FC19; Mon, 25 May 2009 18:01:03 +0000 (UTC) (envelope-from itetcu@FreeBSD.org) Received: from it.buh.tecnik93.com (localhost [127.0.0.1]) by it.buh.tecnik93.com (Postfix) with ESMTP id 9A2A72C50CC3; Mon, 25 May 2009 21:01:30 +0300 (EEST) Date: Mon, 25 May 2009 21:01:25 +0300 From: Ion-Mihai Tetcu To: David Naylor Message-ID: <20090525210125.1239c21e@it.buh.tecnik93.com> In-Reply-To: <200905251003.15408.naylor.b.david@gmail.com> References: <20090523.182426.193741786.chat95@mac.com> <200905241026.26903.naylor.b.david@gmail.com> <20090524223745.4bbc5420@it.buh.tecnik93.com> <200905251003.15408.naylor.b.david@gmail.com> X-Mailer: Claws Mail 3.7.1 (GTK+ 2.16.1; i386-portbld-freebsd7.1) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/x/NOoBX3gP=AW6bgLPbGs32"; protocol="application/pgp-signature" Cc: pgollucci@p6m7g8.com, pav@freebsd.org, freebsd-ports@freebsd.org Subject: Re: MAKE_JOBS_UNSAFE (some more ports) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2009 18:01:04 -0000 --Sig_/x/NOoBX3gP=AW6bgLPbGs32 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 25 May 2009 10:03:12 +0200 David Naylor wrote: > On Sunday 24 May 2009 21:37:45 Ion-Mihai Tetcu wrote: > > On Sun, 24 May 2009 10:26:23 +0200 > > > > David Naylor wrote: > > > On Sunday 24 May 2009 00:16:37 Maho NAKATA wrote: > > > > Hi I tested it yesterday, > > > > > > > > 1. > > > > I need > > > > > > > > > MAKE_JOBS_SAFE=3D yes > > > > > > > > in the Makefile. > > > > > > Yes, you would need that. I believe that will be default. > > > > > > > 2. with above patch, ooo2 doesn't launch parallele jobs. > > > > > > I spotted that problem after submitting the patch, if you > > > explicitly set MAKE_JOBS_NUMBER to something it will work. > > > > > > The problem is that ooo2 does (in effect): > > > .if (${MAKE_JOBS_NUMBER} > 1) > > > # Stuff > > > .else > > > # Other stuff > > > .endif > > > and that doesn't work as expected with MAKE_JOBS_NUMBER=3D`sysctl > > > kern.smp.cpus` as the command is not resolved. > > > > w/o patch > > editors/openoffice.org-3 openoffice.org-3.1.0 4:53:27 > > > > with patch: > > + MAKE_JOBS_SAFE=3D yes > > + MAKE_JOBS_NUMBER=3D 4 > > + MAXPROCESSES?=3D ${MAKE_JOBS_NUMBER} > > + MAXMODULES?=3D ${MAKE_JOBS_NUMBER} > > > > editors/openoffice.org-3 openoffice.org-3.1.0 48:51 > > > > The build is done in > > /dev/md0 on /usr/local/tinderbox/7-STABLE-FPT-NPD (ufs, > > asynchronous, local, noatime) >=20 > Wow, that is quite a speedup. Is it even possible (4 * 60 + 53)/4 =3D > 73, and you get 48 (that is 152% scaling efficiency). This would > mean a serious performance problem with the ooo3 build script and > MAX* =3D1. =20 >=20 > I'll make a patch tonight (+10 hours) that will fix ooo2 in the > default case. You can test ooo2 with patch and MAKE_JOBS_NUMBER > preset (not using default value) and MAKE_JOBS_SAFE=3Dyes. BTW, what about using the same vars for parallel building in all OOo port? --=20 IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" FreeBSD committer -> itetcu@FreeBSD.org, PGP Key ID 057E9F8B493A297B --Sig_/x/NOoBX3gP=AW6bgLPbGs32 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iEYEARECAAYFAkoa3PoACgkQJ7GIuiH/oeXRBgCfXH8aXIxThDkaEuLDsrcjQVHe 4McAnjw7v0+9yJsdKh97+2p9uNBTGlFa =gc+s -----END PGP SIGNATURE----- --Sig_/x/NOoBX3gP=AW6bgLPbGs32--