From owner-svn-src-all@FreeBSD.ORG  Mon Dec 20 15:34:20 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D4398106564A;
	Mon, 20 Dec 2010 15:34:20 +0000 (UTC)
	(envelope-from bruce@cran.org.uk)
Received: from muon.cran.org.uk (muon.cran.org.uk
	[IPv6:2a01:348:0:15:5d59:5c40:0:1])
	by mx1.freebsd.org (Postfix) with ESMTP id 61B9C8FC08;
	Mon, 20 Dec 2010 15:34:20 +0000 (UTC)
Received: from muon.cran.org.uk (localhost [127.0.0.1])
	by muon.cran.org.uk (Postfix) with ESMTP id 83CFEE61EB;
	Mon, 20 Dec 2010 15:34:19 +0000 (GMT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=cran.org.uk; h=date:from
	:to:cc:subject:message-id:in-reply-to:references:mime-version
	:content-type:content-transfer-encoding; s=mail; bh=dWpa1o9rB8Sw
	OLcZfcCFKsc9B8M=; b=Y2LuxgDayLp/NZpP/52p3bi5nJoWOrbTIq057BCdaxCZ
	JGSnbLSQ0NCGr44U5EHA3HvqlULSLzhE9vXcL3/DK2rEjY3XpkbcH+5vmAjfm35g
	hrp6OR+hzUgRXG7AJ3t7auL6oV4FjAZsCNtTV7LcvVQyC12sy/OqwIwcH07Ar8k=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=cran.org.uk; h=date:from:to
	:cc:subject:message-id:in-reply-to:references:mime-version
	:content-type:content-transfer-encoding; q=dns; s=mail; b=HDWLoP
	GCEJQLxv82j2q9f4Tm0B/UK9li4JWmOqQ0Ur8d+4Nteodv0x2Wy3BPLDlfBX/RrS
	hgXSRrpzwNGMxYCafczs1EwD1GGtWh/xxFbN2Cg89dvulIZGm6aC7OLCEXNOKx52
	0s9I+EetCHc/w0sMAD7BQ6Vc/pZ4+JeT1EVTQ=
Received: from unknown (client-86-29-47-22.glfd.adsl.virginmedia.com
	[86.29.47.22])
	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	by muon.cran.org.uk (Postfix) with ESMTPSA id 1DDDCE61E8;
	Mon, 20 Dec 2010 15:34:19 +0000 (GMT)
Date: Mon, 20 Dec 2010 15:34:05 +0000
From: Bruce Cran <bruce@cran.org.uk>
To: Anonymous <swell.k@gmail.com>
Message-ID: <20101220153405.00005692@unknown>
In-Reply-To: <86tyi8law3.fsf@gmail.com>
References: <201009162231.o8GMV3Ov009118__30279.1559639902$1284676285$gmane$org@svn.freebsd.org>
	<86tyi8law3.fsf@gmail.com>
X-Mailer: Claws Mail 3.7.6 (GTK+ 2.16.0; i586-pc-mingw32msvc)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, "David E. O'Brien" <obrien@FreeBSD.org>
Subject: Re: svn commit: r212770 - head/usr.bin/script
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Dec 2010 15:34:20 -0000

On Mon, 20 Dec 2010 18:30:36 +0300
Anonymous <swell.k@gmail.com> wrote:

> "David E. O'Brien" <obrien@FreeBSD.org> writes:
> > +	if (av[0])
> > +		for (k = 0 ; av[k] ; ++k)
> > +			fprintf(fscript, "%s%s", k ? " " : "",
> > av[k]);
> > +		fprintf(fscript, "\r\n");
> > +
> 
> An indent bug? 2nd fprintf() call is not under if(av[0]).

But the 2nd printf() call isn't in the scope of the if statement.
Personally I prefer braces if a statement is longer than 1 line, even
if not strictly required.

-- 
Bruce Cran