From owner-freebsd-ports@freebsd.org Sat Mar 21 02:25:10 2020 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9323B27ADAA for ; Sat, 21 Mar 2020 02:25:10 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from hz.grosbein.net (hz.grosbein.net [IPv6:2a01:4f8:c2c:26d8::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 48kkxx1k1Mz4dRg for ; Sat, 21 Mar 2020 02:25:08 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from eg.sd.rdtc.ru (eg.sd.rdtc.ru [IPv6:2a03:3100:c:13:0:0:0:5]) by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id 02L2P0BJ090319 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 21 Mar 2020 02:25:00 GMT (envelope-from eugen@grosbein.net) X-Envelope-From: eugen@grosbein.net X-Envelope-To: kremels@kreme.com Received: from [10.58.0.10] (dadvw [10.58.0.10]) by eg.sd.rdtc.ru (8.15.2/8.15.2) with ESMTPS id 02L2OxVv020553 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 21 Mar 2020 09:24:59 +0700 (+07) (envelope-from eugen@grosbein.net) Subject: Re: lsof marked ignored To: "@lbutlr" , FreeBSD References: <37AE5B1C-8F5C-4CE7-BB8C-8FD631C5F394@kreme.com> <24181.8991.414308.19079@jerusalem.litteratus.org> From: Eugene Grosbein Message-ID: <032c7d12-6d60-3d08-f747-fce6b3ca03f9@grosbein.net> Date: Sat, 21 Mar 2020 09:24:49 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=0.3 required=5.0 tests=BAYES_00,LOCAL_FROM, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Report: * -2.3 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.0 SPF_PASS SPF: sender matches SPF record * 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record * 2.6 LOCAL_FROM From my domains X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on hz.grosbein.net X-Rspamd-Queue-Id: 48kkxx1k1Mz4dRg X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=permerror (mx1.freebsd.org: domain of eugen@grosbein.net uses mechanism not recognized by this client) smtp.mailfrom=eugen@grosbein.net X-Spamd-Result: default: False [-3.75 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.93)[-0.929,0]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-0.87)[-0.867,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[grosbein.net]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; R_SPF_PERMFAIL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; IP_SCORE(-1.85)[ip: (-5.14), ipnet: 2a01:4f8::/29(-2.57), asn: 24940(-1.54), country: DE(-0.02)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Mar 2020 02:25:10 -0000 21.03.2020 4:30, @lbutlr wrote: > On 20 Mar 2020, at 14:10, Robert Huff wrote: >> Adam Weinberger writes: >> >>>> ===>>> Currently installed version: lsof-4.93.2_9,8 >>>> ===>>> Port directory: /usr/ports/sysutils/lsof >>>> >>>> ===>>> This port is marked IGNORE >>>> ===>>> requires kernel sources >>> >>> That error should only occur if system sources are missing from >>> /usr/src. Check that they're still there, and if not then check them >>> out from svn. >> >> (Last time I checked ....) >> Not only does it require kernel sources, but those sources need >> to match the running kernel. > > Why was this changed (I did not install the source and my /usr/src/ directory is empty and has been since I moved to 12.1) Nothing changed really. lsof needs the whole file sys/fs/pseudofs/pseudofs.h for struct pfs_node and all other parts (types etc.) it uses from same file and it needs the definition of struct lock_owner from sys/kern/kern_lock.c. It tastes some other files in sys/ to enable -DHAS_LOCKF_ENTRY -DHAS_PAUSE_SBT -DHAS_CDEV2PRIV -DHASFUSEFS -DHAS_ZFS but does not really needs their contents, so these flags could be enabled unconditionally by the port. So if we could "export" pseudofs.h and struct lock_owner to /usr/include, then lsof could be built without need of kernel sources.