From owner-svn-src-all@freebsd.org Thu Mar 10 22:37:37 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 67924ACBF93; Thu, 10 Mar 2016 22:37:37 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 598B4398; Thu, 10 Mar 2016 22:37:37 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 509681879; Thu, 10 Mar 2016 22:37:37 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 1CCF51EC63; Thu, 10 Mar 2016 22:37:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id xPxLNtQPFDWY; Thu, 10 Mar 2016 22:37:34 +0000 (UTC) Subject: Re: svn commit: r296589 - head/sys/dev/fdc DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 3D9321EC5D To: Warner Losh , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201603100033.u2A0X6uN027771@repo.freebsd.org> From: Bryan Drewery Organization: FreeBSD Message-ID: <56E1F72D.7000002@FreeBSD.org> Date: Thu, 10 Mar 2016 14:37:33 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <201603100033.u2A0X6uN027771@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2016 22:37:37 -0000 On 3/9/16 4:33 PM, Warner Losh wrote: > Author: imp > Date: Thu Mar 10 00:33:06 2016 > New Revision: 296589 > URL: https://svnweb.freebsd.org/changeset/base/296589 > > Log: > Stop assuming that bio_cmd is a bit field. > > Differential Revision: https://reviews.freebsd.org/D5587 > > Modified: > head/sys/dev/fdc/fdc.c > > Modified: head/sys/dev/fdc/fdc.c > ============================================================================== > --- head/sys/dev/fdc/fdc.c Thu Mar 10 00:27:10 2016 (r296588) > +++ head/sys/dev/fdc/fdc.c Thu Mar 10 00:33:06 2016 (r296589) > @@ -941,7 +941,7 @@ fdc_worker(struct fdc_data *fdc) > /* Disable ISADMA if we bailed while it was active */ > if (fd != NULL && (fd->flags & FD_ISADMA)) { > isa_dmadone( > - bp->bio_cmd & BIO_READ ? ISADMA_READ : ISADMA_WRITE, > + bp->bio_cmd == BIO_READ ? ISADMA_READ : ISADMA_WRITE, I think we should have some kind of file (like ports CHANGES) that lists subtle KPI changes. This and the bio bzero change were easily missed and could lead to who-knows-what downstream for vendors or even out-of-tree modules. Btw there are some missed still: ./dev/mfi/mfi.c: switch (bio->bio_cmd & 0x03) { ./dev/mfi/mfi.c: switch (bio->bio_cmd & 0x03) { -- Regards, Bryan Drewery