Date: Mon, 11 Dec 2023 16:03:09 +0100 From: Kristof Provost <kp@FreeBSD.org> To: Dimitry Andric <dim@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 5c16e71d30c3 - main - Merge llvm-project release/17.x llvmorg-17.0.6-0-g6009708b4367 Message-ID: <E65EEC14-9547-472F-B5EB-7CC70956BBBC@FreeBSD.org> In-Reply-To: <202312081739.3B8HdJYC068067@gitrepo.freebsd.org> References: <202312081739.3B8HdJYC068067@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=_MailMate_3A3E899A-1A08-45A1-8DA9-E72DA079425D_= Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 8 Dec 2023, at 18:39, Dimitry Andric wrote: > The branch main has been updated by dim: > > URL: = > https://cgit.FreeBSD.org/src/commit/?id=3D5c16e71d30c388dd43b217de10a3c= cb4b0219d0d > > commit 5c16e71d30c388dd43b217de10a3ccb4b0219d0d > Merge: b121cb0095c8 703029dbba78 > Author: Dimitry Andric <dim@FreeBSD.org> > AuthorDate: 2023-11-30 20:06:52 +0000 > Commit: Dimitry Andric <dim@FreeBSD.org> > CommitDate: 2023-12-08 17:35:59 +0000 > > Merge llvm-project release/17.x llvmorg-17.0.6-0-g6009708b4367 > > This updates llvm, clang, compiler-rt, libc++, libunwind, lld, = > lldb and > openmp to llvmorg-17.0.6-0-g6009708b4367. > > PR: 273753 > MFC after: 1 month > There appears to be some fallout in some ports. For example, devel/ivykis (but also sysutils/flashrom and = databases/rrdtool) fails like this: /bin/sh ../libtool --tag=3DCC --mode=3Dlink cc -O2 -pipe = -fstack-protector-strong -fno-strict-aliasing -Wall -version-info = 5:6:5 -Wl,--version-script,../libivykis.posix.ver = -fstack-protector-strong -o libivykis.la -rpath /usr/local/lib iv_avl.lo = iv_event.lo iv_fatal.lo iv_task.lo iv_timer.lo iv_tls.lo iv_work.lo = iv_event_raw_posix.lo iv_fd.lo iv_fd_poll.lo iv_fd_pump.lo = iv_main_posix.lo iv_popen.lo iv_signal.lo iv_thread_posix.lo = iv_tid_posix.lo iv_time_posix.lo iv_wait.lo iv_fd_kqueue.lo libtool: link: cc -shared -fPIC -DPIC .libs/iv_avl.o .libs/iv_event.o = =2Elibs/iv_fatal.o .libs/iv_task.o .libs/iv_timer.o .libs/iv_tls.o = =2Elibs/iv_work.o .libs/iv_event_raw_posix.o .libs/iv_fd.o = =2Elibs/iv_fd_poll.o .libs/iv_fd_pump.o .libs/iv_main_posix.o = =2Elibs/iv_popen.o .libs/iv_signal.o .libs/iv_thread_posix.o = =2Elibs/iv_tid_posix.o .libs/iv_time_posix.o .libs/iv_wait.o = =2Elibs/iv_fd_kqueue.o -O2 -fstack-protector-strong = -Wl,--version-script -Wl,../libivykis.posix.ver -fstack-protector-strong = -Wl,-soname -Wl,libivykis.so.0 -o .libs/libivykis.so.0.5.6 ld: error: version script assignment of 'IVYKIS_0.29' to symbol = 'iv_inotify_register' failed: symbol not defined ld: error: version script assignment of 'IVYKIS_0.29' to symbol = 'iv_inotify_unregister' failed: symbol not defined ld: error: version script assignment of 'IVYKIS_0.29' to symbol = 'iv_inotify_watch_register' failed: symbol not defined ld: error: version script assignment of 'IVYKIS_0.29' to symbol = 'iv_inotify_watch_unregister' failed: symbol not defined cc: error: linker command failed with exit code 1 (use -v to see = invocation) I believe the issue is that it doesn=E2=80=99t build inotify code on Free= BSD, = but still mentions the relevant functions in the linker script. The = other affected ports I=E2=80=99ve run into appear to have similar issues.= There=E2=80=99s likely to be a fair amount of fallout from that, e.g. = https://github.com/llvm/llvm-project/issues/75056 I=E2=80=99m not sure what the best path forward is. Should we try to make= ld = warn but not fail on issues like that, or fix each affected port or ? Best regards, Kristof --=_MailMate_3A3E899A-1A08-45A1-8DA9-E72DA079425D_= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html> <html> <head> <meta http-equiv=3D"Content-Type" content=3D"text/xhtml; charset=3Dutf-8"= > </head> <body><div style=3D"font-family: sans-serif;"><div class=3D"markdown" sty= le=3D"white-space: normal;"> <p dir=3D"auto">On 8 Dec 2023, at 18:39, Dimitry Andric wrote:</p> </div><div class=3D"plaintext" style=3D"white-space: normal;"><blockquote= style=3D"margin: 0 0 5px; padding-left: 5px; border-left: 2px solid #136= BCE; color: #136BCE;"><p dir=3D"auto">The branch main has been updated by= dim:</p> <p dir=3D"auto">URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3D= 5c16e71d30c388dd43b217de10a3ccb4b0219d0d">https://cgit.FreeBSD.org/src/co= mmit/?id=3D5c16e71d30c388dd43b217de10a3ccb4b0219d0d</a></p> <p dir=3D"auto">commit 5c16e71d30c388dd43b217de10a3ccb4b0219d0d <br> Merge: b121cb0095c8 703029dbba78 <br> Author: Dimitry Andric <dim@FreeBSD.org> <br> AuthorDate: 2023-11-30 20:06:52 +0000 <br> Commit: Dimitry Andric <dim@FreeBSD.org> <br> CommitDate: 2023-12-08 17:35:59 +0000</p> <p dir=3D"auto"> Merge llvm-project release/17.x llvmorg-17.0.6-0-g600= 9708b4367</p> <p dir=3D"auto"> This updates llvm, clang, compiler-rt, libc++, libunw= ind, lld, lldb and <br> openmp to llvmorg-17.0.6-0-g6009708b4367.</p> <p dir=3D"auto"> PR: 273753 <br> MFC after: 1 month</p> <br></blockquote></div> <div class=3D"markdown" style=3D"white-space: normal;"> <p dir=3D"auto">There appears to be some fallout in some ports.</p> <p dir=3D"auto">For example, devel/ivykis (but also sysutils/flashrom and= databases/rrdtool) fails like this:</p> <pre style=3D"margin-left: 15px; margin-right: 15px; padding: 5px; border= : thin solid gray; overflow-x: auto; max-width: 90vw; background-color: #= E4E4E4;"><code style=3D"padding: 0 0.25em; background-color: #E4E4E4;">/b= in/sh ../libtool --tag=3DCC --mode=3Dlink cc -O2 -pipe -fstack-prot= ector-strong -fno-strict-aliasing -Wall -version-info 5:6:5 -Wl,--versi= on-script,../libivykis.posix.ver -fstack-protector-strong -o libivykis.la= -rpath /usr/local/lib iv_avl.lo iv_event.lo iv_fatal.lo iv_task.lo iv_t= imer.lo iv_tls.lo iv_work.lo iv_event_raw_posix.lo iv_fd.lo iv_fd_poll.l= o iv_fd_pump.lo iv_main_posix.lo iv_popen.lo iv_signal.lo iv_thread_posi= x.lo iv_tid_posix.lo iv_time_posix.lo iv_wait.lo iv_fd_kqueue.lo libtool: link: cc -shared -fPIC -DPIC .libs/iv_avl.o .libs/iv_event.o .= libs/iv_fatal.o .libs/iv_task.o .libs/iv_timer.o .libs/iv_tls.o .libs/iv_= work.o .libs/iv_event_raw_posix.o .libs/iv_fd.o .libs/iv_fd_poll.o .libs/= iv_fd_pump.o .libs/iv_main_posix.o .libs/iv_popen.o .libs/iv_signal.o .li= bs/iv_thread_posix.o .libs/iv_tid_posix.o .libs/iv_time_posix.o .libs/iv_= wait.o .libs/iv_fd_kqueue.o -O2 -fstack-protector-strong -Wl,--version= -script -Wl,../libivykis.posix.ver -fstack-protector-strong -Wl,-soname= -Wl,libivykis.so.0 -o .libs/libivykis.so.0.5.6 ld: error: version script assignment of 'IVYKIS_0.29' to symbol 'iv_inoti= fy_register' failed: symbol not defined ld: error: version script assignment of 'IVYKIS_0.29' to symbol 'iv_inoti= fy_unregister' failed: symbol not defined ld: error: version script assignment of 'IVYKIS_0.29' to symbol 'iv_inoti= fy_watch_register' failed: symbol not defined ld: error: version script assignment of 'IVYKIS_0.29' to symbol 'iv_inoti= fy_watch_unregister' failed: symbol not defined cc: error: linker command failed with exit code 1 (use -v to see invocati= on) </code></pre> <p dir=3D"auto">I believe the issue is that it doesn=E2=80=99t build inot= ify code on FreeBSD, but still mentions the relevant functions in the lin= ker script. The other affected ports I=E2=80=99ve run into appear to have= similar issues.</p> <p dir=3D"auto">There=E2=80=99s likely to be a fair amount of fallout fro= m that, e.g. <a href=3D"https://github.com/llvm/llvm-project/issues/75056= ">https://github.com/llvm/llvm-project/issues/75056</a></p>; <p dir=3D"auto">I=E2=80=99m not sure what the best path forward is. Shoul= d we try to make ld warn but not fail on issues like that, or fix each af= fected port or ?</p> <p dir=3D"auto">Best regards,<br> Kristof</p> </div> </div> </body> </html> --=_MailMate_3A3E899A-1A08-45A1-8DA9-E72DA079425D_=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E65EEC14-9547-472F-B5EB-7CC70956BBBC>