From nobody Fri Apr 17 16:57:58 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fy1KS2gkzz6791h for ; Fri, 17 Apr 2026 16:58:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fy1KS0js2z3flV for ; Fri, 17 Apr 2026 16:58:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776445084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Pc3xUDDH33cg3f7ctOC1IsPeeSshVVe+RnXnLalISo8=; b=R7apnk0nSAF9vF9UUTQ4jZ/PyGqdJ2nukNmFKdfoMDZ5dmAh9Dx7+mEWo93Ew7GSyds+DC EczvaHPORIiKY+tlZM+n2/2CVv+j2C9JCSxmAhHM6DVkAg4JyJDYrPeOjB59J9LIRBPY45 SDYMNubLQ4Y6W5cO1INomtMJgSx+WcLAbuLs6SqNTwXntBI0kfH7FDv8zLHIgIbaZlywMh WjknifyIAtUEr9vWy3b+sd5LyQ7U1Z7zGA6nwvhvHwoTpxHWGV9cyrxVcxELZmrfz5kI89 LeoSFcVrP2gYs44AQ+7iAkdok0QotGbFIq5M3rWnUIK8YqaDuR4xyWXkXjWuWQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776445084; a=rsa-sha256; cv=none; b=xHVTh/ta0wj4sX+4j+Rkm2z8JW3tWxac0CmQ+B5aLqaEWNXWeeBB1PB7v3zFyE+YJmTAkZ ZhZqQepLw63/E0BWfAXA4xbdFZr7VVfPcd75YRPD3QD2U4J4082L+X/yAigfM6DE5gQ/UD im+No2X6CJpTYU9I9hgkBpDDvgI+3OAW9pHExVGn3VRJTWQIhWQCf2QdU+M0bDZpEWpL6m 0Q0Gcghs7t1uKtpq3zjgI2TRB+v+v2GYUlgtMRm6DvlYh4tWbxKVude1l+CY/xhVGhNta4 TUOqm+ZeL4U6TWPKTS60k44iCfB8iYVGFnpLGD78OlpQ+W7RliSRiRndzddugA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776445084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Pc3xUDDH33cg3f7ctOC1IsPeeSshVVe+RnXnLalISo8=; b=l9q2dOAZuM10HDWRh99MVSubEy/krBjnmESli2tNVm61liMjiNZaucrPCBuB2ICTgJ+u8m /6CIBVx0TkEzv3KFVDh9nrmNR55TtzuEFL6L5hM+rEUPakMYrHwHD/eg1loYbU47mrwANE XpiEktbS/OkF+tSywEeXRnyJSyInSBKHxaJhB2lTJGpaXK3L/tSidsvmlGDyv4o7JrgVT7 x38jfFSnc9TIHjv0OkLwMO2ot9q7EBkFoR6jqxUFTAMtqaij9UpGYq1FjlIM9gmIL3lV2Z FgFNaZ50LTumBzchjg+iyjPHAh7CaoA055AFInW7+QoStJSfb3PAQ/NW8+KcBQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fy1KR72zVz12pv for ; Fri, 17 Apr 2026 16:58:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 31c1b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 17 Apr 2026 16:57:58 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Lexi Winter Subject: git: eb0279550d52 - main - boot1.chrp: Improve comment for the SLOF hack List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ivy X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: eb0279550d52962241b4178101cd7f7d732eb682 Auto-Submitted: auto-generated Date: Fri, 17 Apr 2026 16:57:58 +0000 Message-Id: <69e26696.31c1b.7490e442@gitrepo.freebsd.org> The branch main has been updated by ivy: URL: https://cgit.FreeBSD.org/src/commit/?id=eb0279550d52962241b4178101cd7f7d732eb682 commit eb0279550d52962241b4178101cd7f7d732eb682 Author: Lexi Winter AuthorDate: 2026-04-17 16:56:33 +0000 Commit: Lexi Winter CommitDate: 2026-04-17 16:56:33 +0000 boot1.chrp: Improve comment for the SLOF hack Since this original comment was written, the actual issue in SLOF was diagnosed and documented in commit 424089a0fc, which fixed it for loader(8). Update the comment in boot1 to be more informative to future readers. MFC after: 3 days Reviewed by: jhibbits, adrian Sponsored by: https://www.patreon.com/bsdivy Differential Revision: https://reviews.freebsd.org/D56470 --- stand/powerpc/boot1.chrp/boot1.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/stand/powerpc/boot1.chrp/boot1.c b/stand/powerpc/boot1.chrp/boot1.c index 1a546f3473e2..1bb06bf82983 100644 --- a/stand/powerpc/boot1.chrp/boot1.c +++ b/stand/powerpc/boot1.chrp/boot1.c @@ -102,14 +102,11 @@ ofwh_t bootdevh; ofwh_t stdinh, stdouth; /* - * Note about the entry point: + * Our entrypoint. * - * For some odd reason, the first page of the load appears to have trouble - * when entering in LE. The first five instructions decode weirdly. - * I suspect it is some cache weirdness between the ELF headers and .text. - * - * Ensure we have a gap between the start of .text and the entry as a - * workaround. + * A bug in the SLOF shipped with some versions of QEMU causes the first + * 32 bytes of .text to be wrongly byte-swapped when loading LE programs. + * As a workaround, we add some padding at the start of the text section. */ __asm(" \n\ .data \n\ @@ -118,7 +115,7 @@ stack: \n\ .space 16384 \n\ \n\ .text \n\ - /* SLOF cache hack */ \n\ + /* SLOF workaround */ \n\ .space 4096 \n\ .globl _start \n\ _start: \n\